It should be enough to remove the entry from meta-inf/services.<br>
<br>
Sent from ProtonMail mobile<br>
<br>
-------- Original Message --------<br>
On 3 Nov 2018, 17:09, Chris Beams wrote:<br>
<br>
> [@ManfredKarrer](https://github.com/ManfredKarrer) wrote:<br>
><br>
>> Maybe [@blabno](https://github.com/blabno) find time to delist not traded coins.<br>
><br>
> Sure. I could possibly do it too, just want to make sure we do it correctly.<br>
><br>
>> I posted at a proposal the stats<br>
><br>
> That's right. Here they are: [bisq-network/proposals#41 (comment)](https://github.com/bisq-network/proposals/issues/41#issue-367090734). That's a complete list (as of the date of the posting) of which coins should be delisted.<br>
><br>
> Is it as simple as just removing the Asset implementations, though? Is there anything else we would need to do to put together a proper backward compatible PR? We talked about implementing delisting under the DAO as logical instead of physical deletion, but that's for the future. For right now, i.e. 0.9.0, I just want to delist this stuff in the simplest way possible while not breaking compatibility.<br>
><br>
>> [...] and added code to easily print it out<br>
><br>
> Can you provide a link to that code, and indicate how to run it if it's not obvious?<br>
><br>
> —<br>
> You are receiving this because you were mentioned.<br>
> Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/issues/1861#issuecomment-435599480), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2FYLUmelJtJT_dVyfMeifxVylaofks5urb-wgaJpZM4YMxg8).

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthxFJ2AZyGxN23bY0lyVz8WbvR8Vks5urcIVgaJpZM4YMxg8">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtg7UHnxMOYiHOY_Ii7f4d_NQjhBeks5urcIVgaJpZM4YMxg8.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno in #1861: It should be enough to remove the entry from meta-inf/services.\n\nSent from ProtonMail mobile\n\n-------- Original Message --------\nOn 3 Nov 2018, 17:09, Chris Beams wrote:\n\n\u003e [@ManfredKarrer](https://github.com/ManfredKarrer) wrote:\n\u003e\n\u003e\u003e Maybe [@blabno](https://github.com/blabno) find time to delist not traded coins.\n\u003e\n\u003e Sure. I could possibly do it too, just want to make sure we do it correctly.\n\u003e\n\u003e\u003e I posted at a proposal the stats\n\u003e\n\u003e That's right. Here they are: [bisq-network/proposals#41 (comment)](https://github.com/bisq-network/proposals/issues/41#issue-367090734). That's a complete list (as of the date of the posting) of which coins should be delisted.\n\u003e\n\u003e Is it as simple as just removing the Asset implementations, though? Is there anything else we would need to do to put together a proper backward compatible PR? We talked about implementing delisting under the DAO as logical instead of physical deletion, but that's for the future. For right now, i.e. 0.9.0, I just want to delist this stuff in the simplest way possible while not breaking compatibility.\n\u003e\n\u003e\u003e [...] and added code to easily print it out\n\u003e\n\u003e Can you provide a link to that code, and indicate how to run it if it's not obvious?\n\u003e\n\u003e —\n\u003e You are receiving this because you were mentioned.\n\u003e Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/issues/1861#issuecomment-435599480), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2FYLUmelJtJT_dVyfMeifxVylaofks5urb-wgaJpZM4YMxg8)."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440",
"url": "https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Delist untraded assets (#1861)",
"sections": [
{
"text": "",
"activityTitle": "**Bernard Labno**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@blabno",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1861,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1861\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1861#issuecomment-435600440"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406001724\n}"
}
],
"themeColor": "26292E"
}
]</script>