<p><b>@devinbileck</b> approved this pull request.</p>

<p>utACK. Looks good to me. Thanks for putting this together!<br>
Just have a few minor comments.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1862#discussion_r230646331">build.gradle</a>:</p>
<pre style='color:#555'>> +        powermockVersion = '2.0.0-beta.5'
+        protobufVersion = '3.5.1'
+        sparkVersion = '2.5.2'
+        springVersion = '4.3.6.RELEASE'
+
+        os = osdetector.os == 'osx' ? 'mac' : osdetector.os == 'windows' ? 'win' : osdetector.os
+    }
+
+    repositories {
+        jcenter()
+        maven { url 'https://jitpack.io' }
+        maven { url 'https://raw.githubusercontent.com/JesusMcCloud/tor-binary/master/release/' }
+    }
+
+    dependencies {
+        testCompile 'junit:junit:4.12'
</pre>
<p>Since you have defined the junit version above, I assume this can be changed to the following?<br>
<code>testCompile "junit:junit:$junitVersion"</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1862#discussion_r230651226">build.gradle</a>:</p>
<pre style='color:#555'>> +
+    protobuf {
+        protoc {
+            artifact = "com.google.protobuf:protoc:$protobufVersion"
+        }
+    }
+
+    dependencies {
+        compile "org.openjfx:javafx-base:11:$os"
+        compile "org.openjfx:javafx-graphics:11:$os"
+        compile "com.google.protobuf:protobuf-java:$protobufVersion"
+        compile 'com.google.code.gson:gson:2.7'
+        compile('com.googlecode.json-simple:json-simple:1.1.1') {
+            exclude(module: 'junit')
+        }
+        compile 'org.springframework:spring-core:4.3.6.RELEASE'
</pre>
<p>Since you have the spring version defined above, I assume this can be changed to the following?<br>
<code>compile "org.springframework:spring-core:$springVersion"</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1862#discussion_r230652276">build.gradle</a>:</p>
<pre style='color:#555'>> +
+    test {
+        systemProperty 'jdk.attach.allowAttachSelf', true
+
+        def jmockit = configurations.testCompile.files.find { it.name.contains("jmockit") }.absolutePath
+        jvmArgs "-javaagent:$jmockit"
+    }
+}
+
+
+configure(project(':desktop')) {
+    apply plugin: 'com.github.johnrengelman.shadow'
+    apply plugin: 'witness'
+    apply from: '../gradle/witness/gradle-witness.gradle'
+
+    version = '0.8.0-SNAPSHOT'
</pre>
<p>A comment that is out of scope for this PR. But perhaps this should be taken out of the gradle file and put into a resource file, similar to how it is done for pricenode?<br>
<code>version = file("src/main/resources/version.txt").text</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1862#pullrequestreview-171428395">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtt2s5WeqSTM_-MrpCSMY3pmcHiM-ks5ur-tZgaJpZM4YNbt1">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtqIIWcW73hUlX8cRMNDv31aUrVloks5ur-tZgaJpZM4YNbt1.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@devinbileck approved #1862"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1862#pullrequestreview-171428395"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1862#pullrequestreview-171428395",
"url": "https://github.com/bisq-network/bisq/pull/1862#pullrequestreview-171428395",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@devinbileck approved 1862",
"sections": [
{
"text": "utACK. Looks good to me. Thanks for putting this together!\r\nJust have a few minor comments.",
"activityTitle": "**Devin Bileck**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@devinbileck",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1862#pullrequestreview-171428395"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406174581\n}"
}
],
"themeColor": "26292E"
}
]</script>