<p><b>@cbeams</b> requested changes on this pull request.</p>

<p>NACK, per suggested formatting changes.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1838#discussion_r230779077">assets/src/main/java/bisq/asset/coins/Mask.java</a>:</p>
<pre style='color:#555'>> + * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Coin;
+
</pre>
⬇️ Suggested change
<pre style="color: #555">-
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1838#discussion_r230779267">assets/src/test/java/bisq/asset/coins/MaskTest.java</a>:</p>
<pre style='color:#555'>> +public class MaskTest extends AbstractAssetTest {
+
+    public MaskTest() {
+        super(new Mask());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("MbxYjp38aUXBuESwsFv8YmRvbQvMhNyJygU6ViLCjM4sUNqFjsHQim9dvzp9p8BVTjdsRkVNrC1Zy3NJRb18hav3CPe5eWn");
+        assertValidAddress("MeGcanFnSr4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38WwS");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("");
+       assertInvalidAddress("Wecj8");
</pre>
⬇️ Suggested change
<pre style="color: #555">-      assertInvalidAddress("Wecj8");
+        assertInvalidAddress("Wecj8");
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1838#discussion_r230779728">assets/src/test/java/bisq/asset/coins/MaskTest.java</a>:</p>
<pre style='color:#555'>> +
+    public MaskTest() {
+        super(new Mask());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("MbxYjp38aUXBuESwsFv8YmRvbQvMhNyJygU6ViLCjM4sUNqFjsHQim9dvzp9p8BVTjdsRkVNrC1Zy3NJRb18hav3CPe5eWn");
+        assertValidAddress("MeGcanFnSr4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38WwS");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("");
+       assertInvalidAddress("Wecj8");
+       assertInvalidAddress("MsopefFnSr4bJFuNoHogCBdDCsqDrNu5Pc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38gWw");
</pre>
⬇️ Suggested change
<pre style="color: #555">-      assertInvalidAddress("MsopefFnSr4bJFuNoHogCBdDCsqDrNu5Pc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38gWw");
+        assertInvalidAddress("MsopefFnSr4bJFuNoHogCBdDCsqDrNu5Pc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38gWw");
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1838#discussion_r230779855">assets/src/test/java/bisq/asset/coins/MaskTest.java</a>:</p>
<pre style='color:#555'>> +    public MaskTest() {
+        super(new Mask());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("MbxYjp38aUXBuESwsFv8YmRvbQvMhNyJygU6ViLCjM4sUNqFjsHQim9dvzp9p8BVTjdsRkVNrC1Zy3NJRb18hav3CPe5eWn");
+        assertValidAddress("MeGcanFnSr4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38WwS");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("");
+       assertInvalidAddress("Wecj8");
+       assertInvalidAddress("MsopefFnSr4bJFuNoHogCBdDCsqDrNu5Pc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqjABdDyGrzMDkhTC38gWw");
+       assertInvalidAddress("MeGcanuyt4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqujABdDyGrzMDkhTC38WwSx");
</pre>
⬇️ Suggested change
<pre style="color: #555">-      assertInvalidAddress("MeGcanuyt4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqujABdDyGrzMDkhTC38WwSx");
+         assertInvalidAddress("MeGcanuyt4bJFuNoHogCBdDCsqDrNu5njPc1Yh1DfsTUTL5dLbbtE119f4vztxXu6fFCKWRmpqujABdDyGrzMDkhTC38WwSx");
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1838#pullrequestreview-171592028">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtg4cQKqYSWT0SHvACjzNWi_8qUTEks5usFIcgaJpZM4X_Ei2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtm2tw7iGUeaZd76amKqnKqMqLAwKks5usFIcgaJpZM4X_Ei2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams requested changes on #1838"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1838#pullrequestreview-171592028"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1838#pullrequestreview-171592028",
"url": "https://github.com/bisq-network/bisq/pull/1838#pullrequestreview-171592028",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@cbeams requested changes on 1838",
"sections": [
{
"text": "NACK, per suggested formatting changes.",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1838#pullrequestreview-171592028"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402409654\n}"
}
],
"themeColor": "26292E"
}
]</script>