<p>A lot of legacy assets are using the deprecated DefaultAddressValidator which provides very basic and insufficient validation (non-null and non-empty). Any new asset implementations are required to provide their own AddressValidator implementation. To bring these legacy assets up to date and in order provide proper validation, they should be updated with an appropriate AddressValidator.</p>
<p>However, as part of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="377049394" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1861" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/1861/hovercard" href="https://github.com/bisq-network/bisq/pull/1861">#1861</a>, a majority of these legacy assets will be delisted. So will need to review this once all untraded assets have been delisted.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1896">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvavoTddlDCBrdSaUR7LDVQ6R9T6ks5us9PBgaJpZM4YUF98">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnNBCsXrQpOgpQhBaB6zf9rQpXQJks5us9PBgaJpZM4YUF98.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Update legacy assets with proper AddressValidator (#1896)"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1896"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1896",
"url": "https://github.com/bisq-network/bisq/issues/1896",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Update legacy assets with proper AddressValidator (#1896)",
"sections": [
{
"text": "",
"activityTitle": "**Devin Bileck**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@devinbileck",
"facts": [
{
"name": "Repository: ",
"value": "bisq-network/bisq"
},
{
"name": "Issue #: ",
"value": 1896
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1896,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1896\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1896"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 407920508\n}"
}
],
"themeColor": "26292E"
}
]</script>