<p>Thus far, my fork of witness has been the bisq-network's de-facto fork, but I guess now we should actually create a fork in the bisq-network org and then merge those two PRs into it. The canonical witness repo is, I believe, now totally unmaintained. I submitted my PR there just for good measure, so others could see it, etc. At this point, I expect neither of ours will ever be merged. So we can just create our own, more official fork for Bisq.</p>
<p>... I've just set this up at <a href="https://github.com/bisq-network/gradle-witness">https://github.com/bisq-network/gradle-witness</a>, and the master branch there now has both our forks. So you can build from there and put together a PR that adds the updated resulting <code>gradle-witness.jar</code> etc. Please include the commit hash that you built witness from in your commit comment that updates the jar. Do a <code>git log --follow</code> on gradle-witness.jar to see how I documented this when adding it originally.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1897#issuecomment-437267534">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtttHLP6RimtYP-_xRHVXvBen8Tz6ks5utSYqgaJpZM4YUGZN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjhBbAQLYYDPVFqivhLvIqEKgEBQks5utSYqgaJpZM4YUGZN.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #1897: Thus far, my fork of witness has been the bisq-network's de-facto fork, but I guess now we should actually create a fork in the bisq-network org and then merge those two PRs into it. The canonical witness repo is, I believe, now totally unmaintained. I submitted my PR there just for good measure, so others could see it, etc. At this point, I expect neither of ours will ever be merged. So we can just create our own, more official fork for Bisq.\r\n\r\n... I've just set this up at https://github.com/bisq-network/gradle-witness, and the master branch there now has both our forks. So you can build from there and put together a PR that adds the updated resulting `gradle-witness.jar` etc. Please include the commit hash that you built witness from in your commit comment that updates the jar. Do a `git log --follow` on gradle-witness.jar to see how I documented this when adding it originally."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1897#issuecomment-437267534"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1897#issuecomment-437267534",
"url": "https://github.com/bisq-network/bisq/issues/1897#issuecomment-437267534",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Resolve deprecated method in gradle-witness prior to moving to Gradle 5 (#1897)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1897,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1897\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1897#issuecomment-437267534"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 407922253\n}"
}
],
"themeColor": "26292E"
}
]</script>