<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1946'>https://github.com/bisq-network/bisq/pull/1946</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix confirmation progress indicator</li>
  <li>Adapt DepositView to use full window width</li>
  <li>Adapt WitdrawalView to use full window width</li>
  <li>Center align address label</li>
  <li>Show hand cursor on all buttons</li>
  <li>Fix TextArea focus line positioning</li>
  <li>Adapt TorSettingsView</li>
  <li>Improve density of payment account fields</li>
  <li>Fix positioning of x and = icons</li>
  <li>Use mono space font in all columns (except button)</li>
  <li>Remove dotted line for disabled text fields</li>
  <li>Synchronize padding between create and take offer views</li>
  <li>Use new brand color for volume</li>
  <li>Adapt show wallet data window popup layout</li>
  <li>Hide percentage value in busy animation</li>
  <li>Hide row focus border in table views</li>
  <li>Increase first line padding</li>
  <li>Reduce visible row count to not exceed window size</li>
  <li>Adapt layout of popup windows</li>
  <li>Position notification popups to be top-right aligned</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-0">core/src/main/resources/i18n/displayStrings.properties</a>
    (60)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-1">desktop/src/main/java/bisq/desktop/bisq.css</a>
    (44)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-2">desktop/src/main/java/bisq/desktop/components/AddressTextField.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-3">desktop/src/main/java/bisq/desktop/components/AddressWithIconAndDirection.java</a>
    (2)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-4">desktop/src/main/java/bisq/desktop/components/BisqTextField.java</a>
    (21)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-5">desktop/src/main/java/bisq/desktop/components/BsqAddressTextField.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-6">desktop/src/main/java/bisq/desktop/components/BusyAnimation.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-7">desktop/src/main/java/bisq/desktop/components/JFXTextAreaSkinBisqStyle.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-8">desktop/src/main/java/bisq/desktop/components/indicator/skin/StaticProgressIndicatorSkin.java</a>
    (113)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-9">desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java</a>
    (29)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-10">desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-11">desktop/src/main/java/bisq/desktop/main/debug/DebugView.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-12">desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.fxml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-13">desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-14">desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java</a>
    (35)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-15">desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.fxml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-16">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-17">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-18">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-19">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-20">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java</a>
    (45)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-21">desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-22">desktop/src/main/java/bisq/desktop/main/overlays/notifications/Notification.java</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-23">desktop/src/main/java/bisq/desktop/main/overlays/windows/EmptyWalletWindow.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-24">desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-25">desktop/src/main/java/bisq/desktop/main/overlays/windows/ManualPayoutTxWindow.java</a>
    (34)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-26">desktop/src/main/java/bisq/desktop/main/overlays/windows/SendAlertMessageWindow.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-27">desktop/src/main/java/bisq/desktop/main/overlays/windows/ShowWalletDataWindow.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-28">desktop/src/main/java/bisq/desktop/main/overlays/windows/TorNetworkSettingsWindow.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-29">desktop/src/main/java/bisq/desktop/main/overlays/windows/downloadupdate/DisplayUpdateDownloadWindow.java</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-30">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java</a>
    (53)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-31">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-32">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-33">desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.fxml</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-34">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1946/files#diff-35">desktop/src/main/java/bisq/desktop/util/FormBuilder.java</a>
    (52)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1946.patch'>https://github.com/bisq-network/bisq/pull/1946.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1946.diff'>https://github.com/bisq-network/bisq/pull/1946.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1946">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvmPVBlZXoDqsJAZ1DCc_3f2iHOXks5uxWmWgaJpZM4YtSPj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtlct69Etu8Nty2-GvIp4FYar5vZoks5uxWmWgaJpZM4YtSPj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Redesign: Addresses issues of #1857 (#1946)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1946"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1946",
"url": "https://github.com/bisq-network/bisq/pull/1946",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Redesign: Addresses issues of #1857 (#1946)",
"sections": [
{
"text": "",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "fbb3020",
"value": "Fix confirmation progress indicator"
},
{
"name": "9480512",
"value": "Adapt DepositView to use full window width"
},
{
"name": "7612fe3",
"value": "Adapt WitdrawalView to use full window width"
},
{
"name": "26c9c40",
"value": "Center align address label"
},
{
"name": "559cd67",
"value": "Show hand cursor on all buttons"
},
{
"name": "5e06153",
"value": "Fix TextArea focus line positioning"
},
{
"name": "a57d3fc",
"value": "Adapt TorSettingsView"
},
{
"name": "d5ea8a6",
"value": "Improve density of payment account fields"
},
{
"name": "c6ba21e",
"value": "Fix positioning of x and = icons"
},
{
"name": "b5f1ed7",
"value": "Use mono space font in all columns (except button)"
},
{
"name": "d848764",
"value": "Remove dotted line for disabled text fields"
},
{
"name": "88955ef",
"value": "Synchronize padding between create and take offer views"
},
{
"name": "3ee5296",
"value": "Use new brand color for volume"
},
{
"name": "7f0439a",
"value": "Adapt show wallet data window popup layout"
},
{
"name": "c969228",
"value": "Hide percentage value in busy animation"
},
{
"name": "15b7b85",
"value": "Hide row focus border in table views"
},
{
"name": "48b4c3c",
"value": "Increase first line padding"
},
{
"name": "5f78103",
"value": "Reduce visible row count to not exceed window size"
},
{
"name": "4c95d03",
"value": "Adapt layout of popup windows"
},
{
"name": "0853f1d",
"value": "Position notification popups to be top-right aligned"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/src/main/resources/i18n/displayStrings.properties](https://github.com/bisq-network/bisq/pull/1946/files#diff-0) (60 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/bisq.css](https://github.com/bisq-network/bisq/pull/1946/files#diff-1) (44 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AddressTextField.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-2) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AddressWithIconAndDirection.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-3) (2 changes)"
},
{
"name": "Added",
"value": "[desktop/src/main/java/bisq/desktop/components/BisqTextField.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-4) (21 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/BsqAddressTextField.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-5) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/BusyAnimation.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-6) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/JFXTextAreaSkinBisqStyle.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-7) (5 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/indicator/skin/StaticProgressIndicatorSkin.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-8) (113 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-9) (29 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-10) (20 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/debug/DebugView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-11) (24 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.fxml](https://github.com/bisq-network/bisq/pull/1946/files#diff-12) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-13) (1 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-14) (35 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.fxml](https://github.com/bisq-network/bisq/pull/1946/files#diff-15) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-16) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-17) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-18) (27 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-19) (5 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-20) (45 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-21) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/notifications/Notification.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-22) (28 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/EmptyWalletWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-23) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/FilterWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-24) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/ManualPayoutTxWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-25) (34 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/SendAlertMessageWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-26) (7 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/ShowWalletDataWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-27) (11 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/TorNetworkSettingsWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-28) (13 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/windows/downloadupdate/DisplayUpdateDownloadWindow.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-29) (17 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-30) (53 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-31) (12 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep4View.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-32) (7 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/settings/network/NetworkSettingsView.fxml](https://github.com/bisq-network/bisq/pull/1946/files#diff-33) (20 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-34) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/util/FormBuilder.java](https://github.com/bisq-network/bisq/pull/1946/files#diff-35) (52 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1946,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1946\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1946"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1946.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1946.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 414524387\n}"
}
],
"themeColor": "26292E"
}
]</script>