<p>Previously, start scripts were generated for both *nix and Windows<br>
platforms, resulting in an unnecessarily cluttered root directory.</p>
<p>With this change, both types of script are still generated, but Windows<br>
.bat scripts are deleted immediately afterward if the user is running a<br>
non-Windows OS (unfortunately, there was no clean way to suppress the<br>
generation of these scripts in the Gradle StartScripts API).</p>
<p>See <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383835215" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1956" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/1956/hovercard" href="https://github.com/bisq-network/bisq/pull/1956">#1956</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1959'>https://github.com/bisq-network/bisq/pull/1959</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Remove .bat scripts unless user OS is Windows</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1959/files#diff-0">build.gradle</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1959/files#diff-1">docs/build.md</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1959.patch'>https://github.com/bisq-network/bisq/pull/1959.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1959.diff'>https://github.com/bisq-network/bisq/pull/1959.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1959">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttSAjEPNcdicVXQc94R4TePJgNQZks5uyQ2ngaJpZM4YxV0y">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtlqYD3JeGzVN7lDaeFqe88dNIMTXks5uyQ2ngaJpZM4YxV0y.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Remove .bat scripts unless user OS is Windows (#1959)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1959"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1959",
"url": "https://github.com/bisq-network/bisq/pull/1959",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Remove .bat scripts unless user OS is Windows (#1959)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "46ee12d",
"value": "Remove .bat scripts unless user OS is Windows"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[build.gradle](https://github.com/bisq-network/bisq/pull/1959/files#diff-0) (3 changes)"
},
{
"name": "Modified",
"value": "[docs/build.md](https://github.com/bisq-network/bisq/pull/1959/files#diff-1) (4 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1959,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1959\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1959"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1959.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1959.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 415587634\n}"
}
],
"themeColor": "26292E"
}
]</script>