<p><b>@sqrrm</b> approved this pull request.</p>

<p>utACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2016#discussion_r237973366">desktop/src/main/java/bisq/desktop/main/dao/burnbsq/assetfee/AssetFeeView.java</a>:</p>
<pre style='color:#555'>> @@ -164,20 +164,29 @@ protected void activate() {
 
         payFeeButton.setOnAction((event) -> {
             Coin listingFee = getListingFee();
-            try {
-                Transaction transaction = assetService.payFee(selectedAsset, listingFee.value);
-                Coin miningFee = transaction.getFee();
-                int txSize = transaction.bitcoinSerialize().length;
-
-                if (!DevEnv.isDevMode()) {
-                    GUIUtil.showBsqFeeInfoPopup(listingFee, miningFee, txSize, bsqFormatter, btcFormatter,
-                            Res.get("dao.burnBsq.assetFee"), () -> doPublishFeeTx(transaction));
-                } else {
-                    doPublishFeeTx(transaction);
+            long days = getDays();
+            // We don't allow shorter periods as it would allow an attacker to try to deactivate other coins by making a
+            // small fee payment to reduce the trial period and look back period.
+            // Still not a perfect solution but should be good enough for now.
</pre>
<p>Good point about an attacked reducing the listing period of a coin. Perhaps we should consider not allowing a shorter period than the one initially chosen when doing a reactivation? It solves this problem and doesn't really reduce usability.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2016#discussion_r237974603">core/src/main/java/bisq/core/dao/governance/param/Param.java</a>:</p>
<pre style='color:#555'>> @@ -110,6 +110,16 @@
     // Min required trade volume to not get de-listed. Check starts after trial period and use trial period afterwards to look back for trade activity.
     ASSET_MIN_VOLUME("0.01", ParamType.BTC, 10, 10),
 
+  /*  // TODO for testnet we want to have a short cycle of about a week
</pre>
<p>This only adds up to 5+ days. Still ok, but proposal phase could be extended to 600 blocks to make it 7 days.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuGmP1WYyJLYg88BmK1JD3H6iPrzks5u0YY-gaJpZM4Y7__x">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZto1n_ALgIoWkVAyJpF27j2tJzfzMks5u0YY-gaJpZM4Y7__x.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm approved #2016"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713",
"url": "https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@sqrrm approved 2016",
"sections": [
{
"text": "utACK",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2016#pullrequestreview-180411713"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418381809\n}"
}
],
"themeColor": "26292E"
}
]</script>