<ul>
<li>
<p>in consideration of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="279166297" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1055" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1055/hovercard" href="https://github.com/bisq-network/bisq/issues/1055">#1055</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="279166883" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1056" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1056/hovercard" href="https://github.com/bisq-network/bisq/issues/1056">#1056</a> I enhanced jtorctl to accept the format of the public_key</p>
</li>
<li>
<p>When using the external Tor feature, the hidden service never gets announced to the Tor network. Hence, it takes literally ages until its hidden service is accessible from outside. The new Netlayer+jtorctl releases now actively announce the service to the Tor network.</p>
</li>
<li>
<p>and there is bad news: jitpack gives me some hard times. It refuses to build the correct commit when a tag is specified (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="381580240" data-permission-text="Issue title is private" data-url="https://github.com/jitpack/jitpack.io/issues/3572" data-hovercard-type="issue" data-hovercard-url="/jitpack/jitpack.io/issues/3572/hovercard" href="https://github.com/jitpack/jitpack.io/issues/3572">jitpack/jitpack.io#3572</a>), so the travis build is expected to fail.</p>
</li>
</ul>
<p>I will give the guys at jitpack a few more days either to come back to me and fix the issue or hopefully, this mysterious caching timeout hits and everything is fine again.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/2009'>https://github.com/bisq-network/bisq/pull/2009</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Use same private_key in NewTor and RunningTor mode</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2009/files#diff-0">build.gradle</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2009/files#diff-1">p2p/src/main/java/bisq/network/p2p/network/NewTor.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2009/files#diff-2">p2p/src/main/java/bisq/network/p2p/network/RunningTor.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2009/files#diff-3">p2p/src/main/java/bisq/network/p2p/network/TorMode.java</a>
(19)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/2009.patch'>https://github.com/bisq-network/bisq/pull/2009.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/2009.diff'>https://github.com/bisq-network/bisq/pull/2009.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2009">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtlybD1fkB87kGaPfnF02GtX1jWMbks5u0RaUgaJpZM4Y7gID">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtssHErsBXz6maEzY-gnC34C3Bi25ks5u0RaUgaJpZM4Y7gID.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[WIP] Use same private_key in NewTor and RunningTor mode + Hiddenservice Fix (#2009)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2009"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2009",
"url": "https://github.com/bisq-network/bisq/pull/2009",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "[WIP] Use same private_key in NewTor and RunningTor mode + Hiddenservice Fix (#2009)",
"sections": [
{
"text": "",
"activityTitle": "**Florian Reimair**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@freimair",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "5d5c4a9",
"value": "Use same private_key in NewTor and RunningTor mode"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[build.gradle](https://github.com/bisq-network/bisq/pull/2009/files#diff-0) (5 changes)"
},
{
"name": "Modified",
"value": "[p2p/src/main/java/bisq/network/p2p/network/NewTor.java](https://github.com/bisq-network/bisq/pull/2009/files#diff-1) (11 changes)"
},
{
"name": "Modified",
"value": "[p2p/src/main/java/bisq/network/p2p/network/RunningTor.java](https://github.com/bisq-network/bisq/pull/2009/files#diff-2) (5 changes)"
},
{
"name": "Modified",
"value": "[p2p/src/main/java/bisq/network/p2p/network/TorMode.java](https://github.com/bisq-network/bisq/pull/2009/files#diff-3) (19 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2009,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2009\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2009"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2009.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2009.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418251267\n}"
}
],
"themeColor": "26292E"
}
]</script>