<ul>
<li>Fix length issue in regular expression of validate() override in main asset coins.<br>
PIVX most likely started the 1+{25,34} that was then proliferated through the copies.<br>
While it likely should be 1+33, I could only confirm that 35 is too long, so the<br>
code is changed to be 1+{24,33} in order to reduce it by the presumed forgotten first<br>
character.</li>
<li>Fixup testInvalidAddresses() to better test regex rules in test asset coins.  The PIVX<br>
base code was testing against 3 addresses, that all had a different first character,<br>
therefore none of the rest of the regular expression was being tested.  Changed those<br>
addresses (and others for other susceptable coins) to accurately test first character<br>
match, length, and invalid characters in the 24 to 33 series.</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2025'>https://github.com/bisq-network/bisq/pull/2025</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Issue 2021 - Asset validation override issues in many coin extensions</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-0">assets/src/main/java/bisq/asset/coins/BitCloud.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-1">assets/src/main/java/bisq/asset/coins/Credits.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-2">assets/src/main/java/bisq/asset/coins/Cryptonodes.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-3">assets/src/main/java/bisq/asset/coins/DRIP.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-4">assets/src/main/java/bisq/asset/coins/FuturoCoin.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-5">assets/src/main/java/bisq/asset/coins/MegaCoin.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-6">assets/src/main/java/bisq/asset/coins/MonetaryUnit.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-7">assets/src/main/java/bisq/asset/coins/Neos.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-8">assets/src/main/java/bisq/asset/coins/NewPowerCoin.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-9">assets/src/main/java/bisq/asset/coins/PIVX.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-10">assets/src/main/java/bisq/asset/coins/PZDC.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-11">assets/src/main/java/bisq/asset/coins/QMCoin.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-12">assets/src/main/java/bisq/asset/coins/SUB1X.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-13">assets/src/main/java/bisq/asset/coins/Wavi.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-14">assets/src/test/java/bisq/asset/coins/BitCloudTest.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-15">assets/src/test/java/bisq/asset/coins/CreditsTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-16">assets/src/test/java/bisq/asset/coins/CryptonodesTest.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-17">assets/src/test/java/bisq/asset/coins/DRIPTest.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-18">assets/src/test/java/bisq/asset/coins/FuturoCoinTest.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-19">assets/src/test/java/bisq/asset/coins/MegaCoinTest.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-20">assets/src/test/java/bisq/asset/coins/NeosTest.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-21">assets/src/test/java/bisq/asset/coins/NewPowerCoinTest.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-22">assets/src/test/java/bisq/asset/coins/PIVXTest.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-23">assets/src/test/java/bisq/asset/coins/PZDCTest.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-24">assets/src/test/java/bisq/asset/coins/QMCoinTest.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2025/files#diff-25">assets/src/test/java/bisq/asset/coins/SUB1XTest.java</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2025.patch'>https://github.com/bisq-network/bisq/pull/2025.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2025.diff'>https://github.com/bisq-network/bisq/pull/2025.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2025">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtpuRaEAxJgDCKr9oY9viEseCJh_zks5u0uV5gaJpZM4Y9FEI">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvTNULtJ5rkdNNHrbLa0f54KPLxZks5u0uV5gaJpZM4Y9FEI.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Issue 2021 - Asset validation override issues in many coin extensions (#2025)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2025"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2025",
"url": "https://github.com/bisq-network/bisq/pull/2025",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Issue 2021 - Asset validation override issues in many coin extensions (#2025)",
"sections": [
{
"text": "",
"activityTitle": "**CaveSpectre11**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@CaveSpectre11",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "2288042",
"value": "Issue 2021 - Asset validation override issues in many coin extensions"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/BitCloud.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-0) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/Credits.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/Cryptonodes.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-2) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/DRIP.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/FuturoCoin.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-4) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/MegaCoin.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-5) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/MonetaryUnit.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-6) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/Neos.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-7) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/NewPowerCoin.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-8) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/PIVX.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-9) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/PZDC.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-10) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/QMCoin.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-11) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/SUB1X.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-12) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/main/java/bisq/asset/coins/Wavi.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-13) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/BitCloudTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-14) (7 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/CreditsTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-15) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/CryptonodesTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-16) (7 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/DRIPTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-17) (7 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/FuturoCoinTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-18) (1 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/MegaCoinTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-19) (7 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/NeosTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-20) (1 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/NewPowerCoinTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-21) (7 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/PIVXTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-22) (9 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/PZDCTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-23) (3 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/QMCoinTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-24) (9 changes)"
},
{
"name": "Modified",
"value": "[assets/src/test/java/bisq/asset/coins/SUB1XTest.java](https://github.com/bisq-network/bisq/pull/2025/files#diff-25) (1 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2025,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2025\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2025"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2025.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2025.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418664712\n}"
}
],
"themeColor": "26292E"
}
]</script>