<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2056'>https://github.com/bisq-network/bisq/pull/2056</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add better comment for opReturn data errors</li>
  <li>Remove log for duration</li>
  <li>Add and rename exception</li>
  <li>Fix reorg issues</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-0">core/src/main/java/bisq/core/dao/node/BsqNode.java</a>
    (92)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-1">core/src/main/java/bisq/core/dao/node/full/FullNode.java</a>
    (76)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-2">core/src/main/java/bisq/core/dao/node/full/RpcService.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-3">core/src/main/java/bisq/core/dao/node/full/network/GetBlocksRequestHandler.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-4">core/src/main/java/bisq/core/dao/node/lite/LiteNode.java</a>
    (43)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-5">core/src/main/java/bisq/core/dao/node/lite/network/LiteNodeNetworkService.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-6">core/src/main/java/bisq/core/dao/node/parser/BlockParser.java</a>
    (51)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-7">core/src/main/java/bisq/core/dao/node/parser/exceptions/BlockHashNotConnectingException.java</a>
    (4)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-8">core/src/main/java/bisq/core/dao/node/parser/exceptions/BlockHeightNotConnectingException.java</a>
    (32)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-9">core/src/main/java/bisq/core/dao/node/parser/exceptions/RequiredReorgFromSnapshotException.java</a>
    (32)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-10">core/src/main/java/bisq/core/dao/state/DaoStateService.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-11">core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-12">core/src/main/java/bisq/core/dao/state/model/DaoState.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-13">core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2056/files#diff-14">p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2056.patch'>https://github.com/bisq-network/bisq/pull/2056.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2056.diff'>https://github.com/bisq-network/bisq/pull/2056.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2056">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtlan6DF2zSj7a9DPxGgl509M4d1nks5u1x54gaJpZM4ZB0Vf">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtpAeNWfeJxiebwnhV9dTFoF4K16Zks5u1x54gaJpZM4ZB0Vf.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Dao fix reorg issues (#2056)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2056"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2056",
"url": "https://github.com/bisq-network/bisq/pull/2056",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Dao fix reorg issues (#2056)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "547c4f0",
"value": "Add better comment for opReturn data errors"
},
{
"name": "dd18c6e",
"value": "Remove log for duration"
},
{
"name": "a42f917",
"value": "Add and rename exception"
},
{
"name": "c0d2d53",
"value": "Fix reorg issues"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/BsqNode.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-0) (92 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/full/FullNode.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-1) (76 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/full/RpcService.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-2) (10 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/full/network/GetBlocksRequestHandler.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-3) (7 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/lite/LiteNode.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-4) (43 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/lite/network/LiteNodeNetworkService.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-5) (9 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/parser/BlockParser.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-6) (51 changes)"
},
{
"name": "Renamed",
"value": "[core/src/main/java/bisq/core/dao/node/parser/exceptions/BlockHashNotConnectingException.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-7) (4 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/node/parser/exceptions/BlockHeightNotConnectingException.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-8) (32 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/node/parser/exceptions/RequiredReorgFromSnapshotException.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-9) (32 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/DaoStateService.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-10) (14 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-11) (24 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/model/DaoState.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-12) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-13) (5 changes)"
},
{
"name": "Modified",
"value": "[p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java](https://github.com/bisq-network/bisq/pull/2056/files#diff-14) (5 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2056,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2056\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2056"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2056.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2056.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 419906911\n}"
}
],
"themeColor": "26292E"
}
]</script>