<p>I have been able to track the issue down to <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063/hovercard" href="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063"><tt>83e1dd3</tt></a>. (and probably the issue, where the appdir uses the default dir as well).</p>
<h3>The issue</h3>
<p><a href="https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L478-L482">https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L478-L482</a> introduces a default value which is used by the options parser if required (i.e. whenever you do not add <code>--baseCurrencyNetwork=BTC_TESTNET</code>)</p>
<p>However, due to <a href="https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L338-L340">https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L338-L340</a><br>
Bisq first parses the <code>commandLineProperties</code> (which already provides the default values due to the abovementioned changes), and thus, the  getProperty-call is satisfied already and the <code>getAppDirProperties()</code> are never asked.</p>
<p>This all boils down to a mostly useless <code>bisq.properties</code> at the moment.</p>
<h3>Fix</h3>
<p>Now, it is not trivial to change the behaviour while keeping the (most welcome) changes of <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063/hovercard" href="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063"><tt>83e1dd3</tt></a>.</p>
<ul>
<li>if we change the order of the property sources, we foreclose overriding bisq.properties-properties with cmdline options</li>
<li>if we partially revert <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063/hovercard" href="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063"><tt>83e1dd3</tt></a>, we create a permanent minefield for future developments</li>
<li>we could use <code>bisq.properties</code> as defaults where applicable. However, we would have to open the <code>BisqEnvironment</code> to <code>BisqExecutable</code></li>
<li>???</li>
</ul>
<p>all in all, I do not want to decide on that alone: <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=301810" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1449498" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a> any ideas?</p>
<h3>other</h3>
<ul>
<li>does <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063/hovercard" href="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063"><tt>83e1dd3</tt></a> deprecate things? for example <a href="https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L207-L335">https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L207-L335</a><br>
and<br>
<a href="https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L445-L502">https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L445-L502</a><br>
which might cleanup the minefield a bit</li>
<li>for the appdir issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386346037" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2019" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2019/hovercard" href="https://github.com/bisq-network/bisq/pull/2019">#2019</a> <a href="https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L425-L428">https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L425-L428</a> might to be responsible.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2048#issuecomment-444149682">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtv7plH-CHb-W0UFqwjcbZ9oAy1NKks5u1po6gaJpZM4ZAn0M">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvG9fdXTr3Lfou1hsluMIWCIrCvLks5u1po6gaJpZM4ZAn0M.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@freimair in #2048: I have been able to track the issue down to 83e1dd37f975a97c56c8aa5337fda29a4b10a063. (and probably the issue, where the appdir uses the default dir as well).\r\n\r\n### The issue\r\n\r\nhttps://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L478-L482 introduces a default value which is used by the options parser if required (i.e. whenever you do not add ```--baseCurrencyNetwork=BTC_TESTNET```)\r\n\r\nHowever, due to https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L338-L340\r\nBisq first parses the ```commandLineProperties``` (which already provides the default values due to the abovementioned changes), and thus, the  getProperty-call is satisfied already and the ```getAppDirProperties()``` are never asked.\r\n\r\nThis all boils down to a mostly useless ```bisq.properties``` at the moment.\r\n\r\n### Fix\r\nNow, it is not trivial to change the behaviour while keeping the (most welcome) changes of 83e1dd37f975a97c56c8aa5337fda29a4b10a063.\r\n- if we change the order of the property sources, we foreclose overriding bisq.properties-properties with cmdline options\r\n- if we partially revert 83e1dd37f975a97c56c8aa5337fda29a4b10a063, we create a permanent minefield for future developments\r\n- we could use ```bisq.properties``` as defaults where applicable. However, we would have to open the ```BisqEnvironment``` to ```BisqExecutable```\r\n- ???\r\n\r\nall in all, I do not want to decide on that alone: @cbeams, @ManfredKarrer any ideas?\r\n\r\n### other\r\n- does 83e1dd37f975a97c56c8aa5337fda29a4b10a063 deprecate things? for example https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L207-L335\r\nand \r\nhttps://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqEnvironment.java#L445-L502\r\nwhich might cleanup the minefield a bit\r\n- for the appdir issue #2019 https://github.com/bisq-network/bisq/blob/83e1dd37f975a97c56c8aa5337fda29a4b10a063/core/src/main/java/bisq/core/app/BisqExecutable.java#L425-L428 might to be responsible."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/2048#issuecomment-444149682"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2048#issuecomment-444149682",
"url": "https://github.com/bisq-network/bisq/issues/2048#issuecomment-444149682",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Changing BTC network does not have any effect (#2048)",
"sections": [
{
"text": "",
"activityTitle": "**Florian Reimair**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@freimair",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2048,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2048\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/2048#issuecomment-444149682"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 419593484\n}"
}
],
"themeColor": "26292E"
}
]</script>