<p>Thanks <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=301810" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> for fixing it so fast! <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1070734" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/freimair">@freimair</a> I merge it already so that users who run from source can this fixed. But please have a look if we need to change that for the other options as well. At least with the path for log files there was an issue as well (which is fixed by not using getProperty).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2063#issuecomment-444562622">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkOWNsq7W-nKC8j1LXMuiThPyYnLks5u1_yLgaJpZM4ZC3Q2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtstQeKjFw59rAvqrKxGIFu5hpNs3ks5u1_yLgaJpZM4ZC3Q2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2063: Thanks @cbeams for fixing it so fast! @freimair I merge it already so that users who run from source can this fixed. But please have a look if we need to change that for the other options as well. At least with the path for log files there was an issue as well (which is fixed by not using getProperty)."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2063#issuecomment-444562622"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2063#issuecomment-444562622",
"url": "https://github.com/bisq-network/bisq/pull/2063#issuecomment-444562622",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Fix base currency option handling (#2063)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2063,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2063\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2063#issuecomment-444562622"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 420181046\n}"
}
],
"themeColor": "26292E"
}
]</script>