<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382">core/src/main/java/bisq/core/dao/node/BsqNode.java</a>:</p>
<pre style='color:#555'>> +
+        try {
+            Block block = blockParser.parseBlock(rawBlock);
+
+            if (pendingBlocks.contains(rawBlock))
+                pendingBlocks.remove(rawBlock);
+
+            // After parsing we check if we have pending blocks we might have received earlier but which have been
+            // not connecting from the latest height we had. The list is sorted by height
+            if (!pendingBlocks.isEmpty()) {
+                // To avoid ConcurrentModificationException we copy the list. It might be altered in the method call
+                ArrayList<RawBlock> tempPendingBlocks = new ArrayList<>(pendingBlocks);
+                for (RawBlock tempPendingBlock : tempPendingBlocks) {
+                    try {
+                        doParseBlock(tempPendingBlock);
+                    } catch (RequiredReorgFromSnapshotException e1) {
</pre>
<p>Tested a bit and did a 6 block reorg by generating 10 blocks, invalidating the fourth of those blocks and generating 10 more blocks. Results in almost 8200 useless iterations.</p>
<p>It also seems to have broken the phase/cycle handling. Created an issue about it, shouldn't have since it's probably due to the reorg handling, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387801663" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2064" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2064/hovercard" href="https://github.com/bisq-network/bisq/issues/2064">#2064</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuEQOXHGN1kt5KViH-Dsvl36qejdks5u1-NagaJpZM4ZB0Vf">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoKfcdH7-PfZg1I74Ps_zmnPTIJjks5u1-NagaJpZM4ZB0Vf.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2056"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382",
"url": "https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@sqrrm commented on 2056",
"sections": [
{
"text": "",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2056#discussion_r239106382"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 419906911\n}"
}
],
"themeColor": "26292E"
}
]</script>