<p>This change <span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #2048.">fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387278801" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2048" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2048/hovercard" href="https://github.com/bisq-network/bisq/issues/2048">#2048</a> by removing the assignment of a default value<br>
for the <code>baseCurrencyNetwork</code> option at the level of the command line<br>
option parser. The assignment of this default was an oversight in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383986386" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1961" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/1961/hovercard" href="https://github.com/bisq-network/bisq/pull/1961">#1961</a><br>
(specifically commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063/hovercard" href="https://github.com/bisq-network/bisq/commit/83e1dd37f975a97c56c8aa5337fda29a4b10a063"><tt>83e1dd3</tt></a>) that did not account for the fact that<br>
users can change the <code>baseCurrencyNetwork</code> value via the Settings screen<br>
in the application. When users change the setting in the application, the new<br>
value is persisted to /bisq.properties, which is handled at<br>
runtime as a PropertySource with lower precedence than the command line<br>
property source, which means that the changed value is never picked up<br>
because the higher-precedence command line PropertySource always has a<br>
default value.</p>
<p>This fix is surgical in that it addresses only this specific option. A<br>
subsequent change should address the more general issue that setting<br>
defaults in the command line option parser always precludes the<br>
possibility of overriding them in bisq.properties. Basically, we should<br>
revert to the previous strategy of reporting what the default value will<br>
be in the help text without actually assigning a default value in the<br>
option parser using the <code>defaultsTo</code> method.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2063'>https://github.com/bisq-network/bisq/pull/2063</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix base currency option handling</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2063/files#diff-0">core/src/main/java/bisq/core/app/BisqExecutable.java</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2063.patch'>https://github.com/bisq-network/bisq/pull/2063.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2063.diff'>https://github.com/bisq-network/bisq/pull/2063.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2063">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgPVWo1d2NUUBCJLrFKwDoKEsqfxks5u19rTgaJpZM4ZC3Q2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgee5aKiI4aAjTJGaMsMAy4LZX9Eks5u19rTgaJpZM4ZC3Q2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix base currency option handling (#2063)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2063"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2063",
"url": "https://github.com/bisq-network/bisq/pull/2063",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Fix base currency option handling (#2063)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "b122ff4",
"value": "Fix base currency option handling"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/app/BisqExecutable.java](https://github.com/bisq-network/bisq/pull/2063/files#diff-0) (8 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2063,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2063\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2063"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2063.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2063.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 420181046\n}"
}
],
"themeColor": "26292E"
}
]</script>