<p>I found issues with download links:</p>
<ul>
<li>primary download links did work in firefox at all (!)</li>
<li>ios showed ios and macos text at the same time</li>
<li>inconsistent os highlighting in download menus (windows and macos particularly)</li>
<li>add fallback text for non-windows-mac-linux users</li>
</ul>
<p>Other notable changes:</p>
<ul>
<li>re-add analytics (the ga initialization script was missing before)</li>
<li>remove all 32-bit links and rename 64-bit links (the '64 Bit' text from <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq-website/commit/3d23ce25b0ff8e080987076ddf467c0436720764/hovercard" href="https://github.com/bisq-network/bisq-website/commit/3d23ce25b0ff8e080987076ddf467c0436720764"><tt>3d23ce2</tt></a> is gone with this PR so that should be an easy merge conflict)</li>
</ul>
<p>So I spent some time yesterday reworking the code and UI for download links. While seemingly minor I figured it worth the time because getting users to download the Bisq software is probably our <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="245351087" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-website/issues/1" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq-website/issues/1/hovercard" href="https://github.com/bisq-network/bisq-website/issues/1">#1</a> goal for the website, and it should be a flawless experience.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> if you or someone with access to Analytics can verify that analytics are working again, that would be great. I was getting ga errors before, and I'm not getting them any more, but I can't be 100% sure events are actually being recorded on the server.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq-website/pull/102'>https://github.com/bisq-network/bisq-website/pull/102</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Revert 88fe6b67d10a937e5068a5493dfa016504b4c619</li>
<li>Remove 32-bit links from download page & menu</li>
<li>Rename '64 bit' links to '.exe' and '.deb'</li>
<li>Add download links to os text</li>
<li>Add fallback download link for non-deb/rpm linux</li>
<li>Refactor os detection in scripts.js</li>
<li>Remove rpm download text/links</li>
<li>Refactor os detection for downloads</li>
<li>Re-enable analytics</li>
<li>Remove comma causing syntax error on chrome</li>
<li>Remove console.log() statements</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-0">_includes/homepage_content.html</a>
(188)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-1">_includes/os_selector_options.html</a>
(27)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-2">_layouts/default.html</a>
(122)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-3">downloads.html</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-4">js/markets.js</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-website/pull/102/files#diff-5">js/scripts.js</a>
(146)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq-website/pull/102.patch'>https://github.com/bisq-network/bisq-website/pull/102.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq-website/pull/102.diff'>https://github.com/bisq-network/bisq-website/pull/102.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/102">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuujPH_gkjhfxeB1wJ-ao6OW3Uchks5u19Q1gaJpZM4ZCzui">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvXx1sMPfLXY5TCKe8TvOuUGU6nHks5u19Q1gaJpZM4ZCzui.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-website","title":"bisq-network/bisq-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Rework download links (#102)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-website/pull/102"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/102",
"url": "https://github.com/bisq-network/bisq-website/pull/102",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Rework download links (#102)",
"sections": [
{
"text": "",
"activityTitle": "**Steve Jain**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@m52go",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "6fe6636",
"value": "Revert 88fe6b67d10a937e5068a5493dfa016504b4c619"
},
{
"name": "906d45e",
"value": "Remove 32-bit links from download page \u0026 menu"
},
{
"name": "0f0ad29",
"value": "Rename '64 bit' links to '.exe' and '.deb'"
},
{
"name": "72760b0",
"value": "Add download links to os text"
},
{
"name": "af16da7",
"value": "Add fallback download link for non-deb/rpm linux"
},
{
"name": "cb16240",
"value": "Refactor os detection in scripts.js"
},
{
"name": "e8a7261",
"value": "Remove rpm download text/links"
},
{
"name": "636adf3",
"value": "Refactor os detection for downloads"
},
{
"name": "0ab7fe4",
"value": "Re-enable analytics"
},
{
"name": "7ebab4b",
"value": "Remove comma causing syntax error on chrome"
},
{
"name": "9006f89",
"value": "Remove console.log() statements"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[_includes/homepage_content.html](https://github.com/bisq-network/bisq-website/pull/102/files#diff-0) (188 changes)"
},
{
"name": "Modified",
"value": "[_includes/os_selector_options.html](https://github.com/bisq-network/bisq-website/pull/102/files#diff-1) (27 changes)"
},
{
"name": "Modified",
"value": "[_layouts/default.html](https://github.com/bisq-network/bisq-website/pull/102/files#diff-2) (122 changes)"
},
{
"name": "Modified",
"value": "[downloads.html](https://github.com/bisq-network/bisq-website/pull/102/files#diff-3) (13 changes)"
},
{
"name": "Modified",
"value": "[js/markets.js](https://github.com/bisq-network/bisq-website/pull/102/files#diff-4) (12 changes)"
},
{
"name": "Modified",
"value": "[js/scripts.js](https://github.com/bisq-network/bisq-website/pull/102/files#diff-5) (146 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-website\",\n\"issueId\": 102,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-website\",\n\"pullRequestId\": 102\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/102"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/102.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/102.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 420166562\n}"
}
],
"themeColor": "26292E"
}
]</script>