<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=33473721" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/BravoIndia">@BravoIndia</a> Thanks for the suggestions! Basically agree to all beside the confirmation popup for vote change, but no strong opinion on that (if at least with a dont show again) - but generally we want to avoid popups if not absolutely needed as there are already way too many.</p>
<p>I think a final confirmation with overview screen would be good like at create offer the final confirm window with all data. Then the user should see if his votes have been as intended.</p>
<p>Do you have a suggestion for Re 1?</p>
<p>Yes links are not validated yet but we could handle the exception to not log. I think its the only place in Bisq where user can edit the URL so on other places its exceptional that a URL does not work.</p>
<p>Re 3: Yes agree would be good to use more realistic situation. Maybe we also can create a dao-testing repo which gets deleted later? Or any other idea for a place where its easy without extra registration to post links? Maybe pastebin?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2071#issuecomment-444940443">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgWh-R4PSAMTOANdjQ62hLYBuSnxks5u2UlFgaJpZM4ZF4Oe">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZttROQZ_qhm0NUQjBW3BHiSaktUKRks5u2UlFgaJpZM4ZF4Oe.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2071: @BravoIndia Thanks for the suggestions! Basically agree to all beside the confirmation popup for vote change, but no strong opinion on that (if at least with a dont show again) - but generally we want to avoid popups if not absolutely needed as there are already way too many.\r\n\r\nI think a final confirmation with overview screen would be good like at create offer the final confirm window with all data. Then the user should see if his votes have been as intended. \r\n\r\nDo you have a suggestion for Re 1?\r\n\r\nYes links are not validated yet but we could handle the exception to not log. I think its the only place in Bisq where user can edit the URL so on other places its exceptional that a URL does not work.\r\n\r\nRe 3: Yes agree would be good to use more realistic situation. Maybe we also can create a dao-testing repo which gets deleted later? Or any other idea for a place where its easy without extra registration to post links? Maybe pastebin? \r\n"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/2071#issuecomment-444940443"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2071#issuecomment-444940443",
"url": "https://github.com/bisq-network/bisq/issues/2071#issuecomment-444940443",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] UI: suggestions for 'DAO -\u003e Governance -\u003e Browse open proposals' page (#2071)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2071,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2071\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/2071#issuecomment-444940443"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 420971422\n}"
}
],
"themeColor": "26292E"
}
]</script>