<p>This request <span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #2084.">fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="388440870" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2084" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2084/hovercard" href="https://github.com/bisq-network/bisq/issues/2084">#2084</a> similar to the fix introduced by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=301810" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387787136" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2063" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/2063/hovercard" href="https://github.com/bisq-network/bisq/pull/2063">#2063</a> (which addressed <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387278801" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/2048" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/2048/hovercard" href="https://github.com/bisq-network/bisq/issues/2048">#2048</a>).</p>
<p>This should get rid of all side-effects we encountered by providing the defaults in the JOptSimple parser already. Since <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383986386" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1961" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/1961/hovercard" href="https://github.com/bisq-network/bisq/pull/1961">#1961</a> did not remove any code concerning the "old" default handling this fix should be production ready.</p>
<p>However, as <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=301810" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383986386" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1961" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/1961/hovercard" href="https://github.com/bisq-network/bisq/pull/1961">#1961</a>, he has further changes regarding the command line argument parsing queued up. So <code>git revert</code> <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/e9ca340ccbf5517e95d5548011f567afedc5e47a/hovercard" href="https://github.com/bisq-network/bisq/commit/e9ca340ccbf5517e95d5548011f567afedc5e47a"><tt>e9ca340</tt></a> (this commit)  and <code>git revert</code> <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/b122ff4104f14868dc50b0a38dd175e1edb7f8f3/hovercard" href="https://github.com/bisq-network/bisq/commit/b122ff4104f14868dc50b0a38dd175e1edb7f8f3"><tt>b122ff4</tt></a> should prepare Bisq for your queued changes again.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2090'>https://github.com/bisq-network/bisq/pull/2090</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>surgically fixes #2048, fixes #2084</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2090/files#diff-0">core/src/main/java/bisq/core/app/BisqExecutable.java</a>
    (120)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2090.patch'>https://github.com/bisq-network/bisq/pull/2090.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2090.diff'>https://github.com/bisq-network/bisq/pull/2090.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2090">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtj_d0xrTWw7E_VzzQgR3vuY3U3s9ks5u2rnngaJpZM4ZI-KF">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvULFV5A8Yg2yjCGbq1HCoqzj3nMks5u2rnngaJpZM4ZI-KF.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Surgical fix to default command line parameters (#2090)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2090"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2090",
"url": "https://github.com/bisq-network/bisq/pull/2090",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Surgical fix to default command line parameters (#2090)",
"sections": [
{
"text": "",
"activityTitle": "**Florian Reimair**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@freimair",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "e9ca340",
"value": "surgically fixes #2048, fixes #2084"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/app/BisqExecutable.java](https://github.com/bisq-network/bisq/pull/2090/files#diff-0) (120 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 2090,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 2090\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2090"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2090.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2090.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421782149\n}"
}
],
"themeColor": "26292E"
}
]</script>