<ul>
<li>Use Callable instead of Runnable to support exception handling</li>
<li>Add error handler to forward exceptions in threads to client</li>
<li>Add more logs</li>
<li>Add Nullable annotation</li>
<li>Use ListeningExecutorService</li>
<li>Catch generic exceptions</li>
<li>Make NotificationHandlerException checked exception</li>
<li>Set version 0.5.8.4</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/btcd-cli4j/pull/3'>https://github.com/bisq-network/btcd-cli4j/pull/3</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Set Java 8</li>
  <li>Add guava and findbugs</li>
  <li>Add Version class</li>
  <li>Add error handler</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-0">core/pom.xml</a>
    (2)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-1">core/src/main/java/com/neemre/btcdcli4j/core/BtcdCli4jVersion.java</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-2">daemon/pom.xml</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-3">daemon/src/main/java/com/neemre/btcdcli4j/daemon/BtcdDaemonImpl.java</a>
    (57)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-4">daemon/src/main/java/com/neemre/btcdcli4j/daemon/NotificationHandlerException.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-5">daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/NotificationMonitor.java</a>
    (56)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-6">daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/worker/NotificationWorker.java</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-7">daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/worker/NotificationWorkerFactory.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-8">examples/pom.xml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-9">pom.xml</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/btcd-cli4j/pull/3.patch'>https://github.com/bisq-network/btcd-cli4j/pull/3.patch</a></li>
  <li><a href='https://github.com/bisq-network/btcd-cli4j/pull/3.diff'>https://github.com/bisq-network/btcd-cli4j/pull/3.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/btcd-cli4j/pull/3">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtiR8Qy5511E0rUcUaxH1-iLDErGoks5u27tHgaJpZM4ZJoef">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjvTFnCapZHx5TORN-jrP3z7ZG4uks5u27tHgaJpZM4ZJoef.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/btcd-cli4j","title":"bisq-network/btcd-cli4j","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/btcd-cli4j"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add error handlers (#3)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/btcd-cli4j/pull/3"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/btcd-cli4j/pull/3",
"url": "https://github.com/bisq-network/btcd-cli4j/pull/3",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Add error handlers (#3)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "380478d",
"value": "Set Java 8"
},
{
"name": "f3ba4c4",
"value": "Add guava and findbugs"
},
{
"name": "2634535",
"value": "Add Version class"
},
{
"name": "69d8f11",
"value": "Add error handler"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/pom.xml](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-0) (2 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/com/neemre/btcdcli4j/core/BtcdCli4jVersion.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-1) (22 changes)"
},
{
"name": "Modified",
"value": "[daemon/pom.xml](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-2) (12 changes)"
},
{
"name": "Modified",
"value": "[daemon/src/main/java/com/neemre/btcdcli4j/daemon/BtcdDaemonImpl.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-3) (57 changes)"
},
{
"name": "Modified",
"value": "[daemon/src/main/java/com/neemre/btcdcli4j/daemon/NotificationHandlerException.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-4) (2 changes)"
},
{
"name": "Modified",
"value": "[daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/NotificationMonitor.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-5) (56 changes)"
},
{
"name": "Modified",
"value": "[daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/worker/NotificationWorker.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-6) (15 changes)"
},
{
"name": "Modified",
"value": "[daemon/src/main/java/com/neemre/btcdcli4j/daemon/notification/worker/NotificationWorkerFactory.java](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-7) (10 changes)"
},
{
"name": "Modified",
"value": "[examples/pom.xml](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-8) (2 changes)"
},
{
"name": "Modified",
"value": "[pom.xml](https://github.com/bisq-network/btcd-cli4j/pull/3/files#diff-9) (4 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/btcd-cli4j\",\n\"issueId\": 3,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/btcd-cli4j\",\n\"pullRequestId\": 3\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/btcd-cli4j/pull/3"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/btcd-cli4j/pull/3.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/btcd-cli4j/pull/3.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 421955487\n}"
}
],
"themeColor": "26292E"
}
]</script>