<p>There were several errors in the markets graphs and tables on the Markets section with respect to units, prices, and aggregation (averages showing instead of sums).</p>
<p>I also fixed some aesthetic items, such as limiting significant figures (e.g., so decimal numbers don't have 15 digits).</p>
<p>The charting plugin is rather sophisticated so I didn't mess with it too much, but most other code was heavily revised/refactored.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-website/pull/103'>https://github.com/bisq-network/bisq-website/pull/103</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor page initialization</li>
  <li>Refactor get-ticker and get-title functions</li>
  <li>Fix default trade history table</li>
  <li>Fix all trade history tables</li>
  <li>Fix offer tables</li>
  <li>Disable hover highlighting on tablet headers</li>
  <li>Reverse volume with amount to correct past trades</li>
  <li>Fix all charts</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-website/pull/103/files#diff-0">css/styles.css</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-website/pull/103/files#diff-1">js/markets.js</a>
    (540)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-website/pull/103/files#diff-2">markets.html</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-website/pull/103.patch'>https://github.com/bisq-network/bisq-website/pull/103.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-website/pull/103.diff'>https://github.com/bisq-network/bisq-website/pull/103.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-website/pull/103">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuVomXxLL6AGLKxVOznECz5mz69aks5u3uPTgaJpZM4ZMU21">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuvjPmCltAu-N-7mu6gLbFvimUqLks5u3uPTgaJpZM4ZMU21.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-website","title":"bisq-network/bisq-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix markets graphs (#103)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-website/pull/103"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-website/pull/103",
"url": "https://github.com/bisq-network/bisq-website/pull/103",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Fix markets graphs (#103)",
"sections": [
{
"text": "",
"activityTitle": "**Steve Jain**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@m52go",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "a5c7682",
"value": "Refactor page initialization"
},
{
"name": "9b202b4",
"value": "Refactor get-ticker and get-title functions"
},
{
"name": "1a62da4",
"value": "Fix default trade history table"
},
{
"name": "306acd8",
"value": "Fix all trade history tables"
},
{
"name": "9e6b380",
"value": "Fix offer tables"
},
{
"name": "11fb910",
"value": "Disable hover highlighting on tablet headers"
},
{
"name": "72f60d9",
"value": "Reverse volume with amount to correct past trades"
},
{
"name": "09ba443",
"value": "Fix all charts"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[css/styles.css](https://github.com/bisq-network/bisq-website/pull/103/files#diff-0) (12 changes)"
},
{
"name": "Modified",
"value": "[js/markets.js](https://github.com/bisq-network/bisq-website/pull/103/files#diff-1) (540 changes)"
},
{
"name": "Modified",
"value": "[markets.html](https://github.com/bisq-network/bisq-website/pull/103/files#diff-2) (8 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-website\",\n\"issueId\": 103,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-website\",\n\"pullRequestId\": 103\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/103"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/103.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-website/pull/103.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 422661557\n}"
}
],
"themeColor": "26292E"
}
]</script>