<p><b>@sqrrm</b> requested changes on this pull request.</p>

<p>NACK</p>
<p>Need to change all labels to upper case</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2109#discussion_r240662130">desktop/src/main/java/bisq/desktop/components/MenuItem.java</a>:</p>
<pre style='color:#555'>> @@ -58,7 +58,7 @@ public MenuItem(Navigation navigation,
         this.viewClass = viewClass;
         this.baseNavPath = baseNavPath;
 
-        setLabelText(title);
+        setLabelText(title.toUpperCase());
</pre>
<p>This doesn't handle the 'Vote on proposals'/'Browse open proposals' text that changes depending on phase</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtsMOxXh6SfLk6isKDPIYdmtT2KC3ks5u39HRgaJpZM4ZNZ-r">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtryoeqAIJDs6eNQ96IYms22op3wvks5u39HRgaJpZM4ZNZ-r.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm requested changes on #2109"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037",
"url": "https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@sqrrm requested changes on 2109",
"sections": [
{
"text": "NACK\r\n\r\nNeed to change all labels to upper case",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 422944683\n}"
}
],
"themeColor": "26292E"
}
]</script>