<p><b>@CaveSpectre11</b> requested changes on this pull request.</p>

<p>3 of the Invalid Addresses match the regex; as valid addresses:</p>
<pre><code>$ egrep -v -e '.*valid [S][a-km-zA-HJ-NP-Z1-9]{24,33}$' addresses.txt
invalid sQEasE1ErGeSSqjruzL879UNPeV7sWbnAN
invalid SfCe8XrgG2

 $ egrep -e '.*valid [S][a-km-zA-HJ-NP-Z1-9]{24,33}$' addresses.txt
valid SQEasE1ErGeSSqjruzL879UNPeV7sWbnAN
valid SRK1eahAugt3k6BQjbR1EFYWTAGzg6uXPd
valid SfCe8XrgG2FTPLyuheJ2kMVTD4QehjPUPb
valid SkSJUTCgfJyGM6REhvt54JNQswnwsGHt5E
invalid SRK1eahBugt3k6BQjbR1EFYWTAGzg6uXpD
invalid SfCe8XrgG2FTPLyuheJ2kMVTD4QehjLULd
invalid SSSJUTCgfJyGM6REhvt54JNQswnwsGHt6e

</code></pre><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2146#discussion_r243724525">assets/src/test/java/bisq/asset/coins/SUNPTest.java</a>:</p>
<pre style='color:#555'>> +    public SUNPTest() {
+        super(new SUNP());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("SQEasE1ErGeSSqjruzL879UNPeV7sWbnAN");
+        assertValidAddress("SRK1eahAugt3k6BQjbR1EFYWTAGzg6uXPd");
+        assertValidAddress("SfCe8XrgG2FTPLyuheJ2kMVTD4QehjPUPb");
+        assertValidAddress("SkSJUTCgfJyGM6REhvt54JNQswnwsGHt5E");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("sQEasE1ErGeSSqjruzL879UNPeV7sWbnAN");
+        assertInvalidAddress("SRK1eahBugt3k6BQjbR1EFYWTAGzg6uXpD");
</pre>
<p>The middle 3 addresses are valid according to your regex</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2146#pullrequestreview-187578526">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkt--cGsziPha16gqx3XhVjsz3zvks5u7afFgaJpZM4ZaVz4">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtueoeR0IwBIKzPBKyGhEfzki-yQwks5u7afFgaJpZM4ZaVz4.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@CaveSpectre11 requested changes on #2146"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2146#pullrequestreview-187578526"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2146#pullrequestreview-187578526",
"url": "https://github.com/bisq-network/bisq/pull/2146#pullrequestreview-187578526",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>