<p>The 64bitBuild.bat script has been renamed to package.bat and has<br>
been updated so that it is capable of performing the complete packaging<br>
process without having to rely on the jar first being built and prepped<br>
from the MacOS scripts. However, it does support having the jar<br>
previously built and prepped and will look for a prepped jar in the<br>
desktop/package folder. If not found, it will build and prep it<br>
prior to packaging the executable.</p>
<p>Additionally, some unnecessary options that were being passed to<br>
javapackager.exe have been eliminated such as BappVersion and Bruntime.<br>
AppVersion is now being passed via environment variables and the<br>
Bruntime option is valid only when the -native option is set to jnlp.</p>
<p>The Bisq.iss file was changed so it no longer needs to be updated with<br>
AppVersion every time as it is being passed from package.bat via<br>
environment variables. Also, AppCopyrightYear does not need to be<br>
updated as it is determined automatically. A few other options were<br>
added or tweaked as well.</p>
<p>Finally, a release.bat script has been added that will perform the<br>
release process of copying necessary files to a versioned release folder<br>
and generating/verifying signatures. Linux and MacOS packaged installers<br>
should be copied to their appropriate package folders prior to<br>
executing this script if they are to be included in this release<br>
process, otherwise only the Windows files will be included.</p>
<p>The MacOS and Linux packaging scripts should be reviewed and updated<br>
accordingly.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2163'>https://github.com/bisq-network/bisq/pull/2163</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Update windows packaging process</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-0">desktop/package/macosx/create_app.sh</a>
    (2)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-1">desktop/package/tools-1.0.jar</a>
    (0)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-2">desktop/package/windows/64bitBuild.bat</a>
    (29)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-3">desktop/package/windows/Bisq.iss</a>
    (22)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-4">desktop/package/windows/package.bat</a>
    (118)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2163/files#diff-5">desktop/package/windows/release.bat</a>
    (70)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2163.patch'>https://github.com/bisq-network/bisq/pull/2163.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2163.diff'>https://github.com/bisq-network/bisq/pull/2163.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2163">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgYWDQ0KNvjkqhjzhEtY9LaJzx1hks5u7rYUgaJpZM4Zfo3k">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuN4uV2Kj_tlFiIz4VBZDgLw79f1ks5u7rYUgaJpZM4Zfo3k.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Update windows packaging process (#2163)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2163"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2163",
"url": "https://github.com/bisq-network/bisq/pull/2163",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>