<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comments</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2170#discussion_r245659028">assets/src/main/java/bisq/asset/coins/SUNP.java</a>:</p>
<pre style='color:#555'>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.AddressValidationResult;
+import bisq.asset.Base58BitcoinAddressValidator;
+import bisq.asset.Coin;
+import bisq.asset.NetworkParametersAdapter;
+
+public class SUNP extends Coin {
</pre>
<p>Class name should be <code>Sunplatform</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2170#discussion_r245659070">assets/src/test/java/bisq/asset/coins/SUNPTest.java</a>:</p>
<pre style='color:#555'>> + * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.AbstractAssetTest;
+
+import org.junit.Test;
+
+public class SUNPTest extends AbstractAssetTest {
</pre>
<p>SunplatformTest</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2170#pullrequestreview-189814686">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmjlt3i8Gv4AZwpIu2OW23yLHNZBks5vA1EdgaJpZM4ZgYQp">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtpeHEx4bi8kAlPlX-e4D28Km5l2tks5vA1EdgaJpZM4ZgYQp.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno requested changes on #2170"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2170#pullrequestreview-189814686"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2170#pullrequestreview-189814686",
"url": "https://github.com/bisq-network/bisq/pull/2170#pullrequestreview-189814686",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>