<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2190#discussion_r245584056">desktop/package/linux/package.sh</a>:</p>
<pre style='color:#555'>> +    echo Zipping jar again without module config to $jar_file
+    cd $tmp; zip -r -q -X $jar_file *
+    cd $base_dir; rm -rf $tmp
+
+    echo SHA256 before stripping jar file:
+    shasum -a256 $jar_file | awk '{print $1}'
+
+    echo Making deterministic jar by stripping out parameters and comments that contain dates
+    # Jar file created from https://github.com/ManfredKarrer/tools
+    # TODO Is this step still necessary? Since we are using preserveFileTimestamps and reproducibleFileOrder in build.gradle
+    java -jar $base_dir/desktop/package/tools-1.0.jar $jar_file
+
+    echo SHA256 after stripping jar file:
+    shasum -a256 $jar_file | awk '{print $1}' | tee $base_dir/desktop/package/desktop-$version-all.jar.txt
+
+    chmod o+rx "$base_dir/desktop/package/desktop-$version-all.jar"
</pre>
<p>This only works when building from source. When using an existing jar file in a virtual box shared folder, we need to copy it locally and change the permissions and reference it from there.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2190#pullrequestreview-189719835">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjdZOC9SbKNg8tA402v1n4lJF7Gwks5vAwxtgaJpZM4Znu-d">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZttlMk583HWPtIiyGLDzUxd7lVIjFks5vAwxtgaJpZM4Znu-d.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx commented on #2190"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2190#pullrequestreview-189719835"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2190#pullrequestreview-189719835",
"url": "https://github.com/bisq-network/bisq/pull/2190#pullrequestreview-189719835",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>