<p>The PR add the Tasks and messages to implement the new trade protocol for the buyer as maker case.<br>
It does not implement any of the new transactions yet.<br>
It completes like a normal trade and just calls the "empty" tasks and send the additional messages.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/2245'>https://github.com/bisq-network/bisq/pull/2245</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Change P2P_NETWORK_VERSION and TRADE_PROTOCOL_VERSION</li>
<li>Rename MakerSendPublishDepositTxRequest</li>
<li>Rename PublishDepositTxRequest</li>
<li>Remove publishing part from takerSignsAndPublishesDepositTx</li>
<li>Rename SellerAsTakerSignAndPublishDepositTx to SellerAsTakerCompletesDepositTx</li>
<li>Add new trade state to reflect completed but not published deposit tx</li>
<li>Rename TakerProcessPublishDepositTxRequest</li>
<li>Add SignTLPayoutTxMessage</li>
<li>Add SellerAsTakerCreatesTLPayoutTx stub</li>
<li>Add SellerAsTakerSendsTLPayoutTx</li>
<li>Add BuyerAsMakerProcessSignTLPayoutTxMessage</li>
<li>Add new tasks to trade protocol</li>
<li>Refactor: Move method</li>
<li>Add TODO and comment</li>
<li>Make SignTLPayoutTxMessage a DirectMessage</li>
<li>Add PublishDepositTxRequest</li>
<li>Add new tasks</li>
<li>Add new tasks to protocols</li>
<li>Update tasks</li>
<li>Add basic PB support</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-0">common/src/main/java/bisq/common/app/Version.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-1">common/src/main/proto/pb.proto</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-2">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>
(118)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-3">core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-4">core/src/main/java/bisq/core/trade/Trade.java</a>
(1)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-5">core/src/main/java/bisq/core/trade/messages/CompleteDepositTxRequest.java</a>
(193)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-6">core/src/main/java/bisq/core/trade/messages/PublishDepositTxRequest.java</a>
(132)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-7">core/src/main/java/bisq/core/trade/messages/SignTLPayoutTxMessage.java</a>
(82)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-8">core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-9">core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-10">core/src/main/java/bisq/core/trade/protocol/SellerAsMakerProtocol.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-11">core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java</a>
(54)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-12">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerProcessSignTLPayoutTxMessage.java</a>
(58)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-13">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerSendsPublishDepositTxMessage.java</a>
(85)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-14">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerSignsTLPayoutTx.java</a>
(41)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-15">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignAndPublishDepositTx.java</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-16">core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerSendCompleteDepositTxRequest.java</a>
(8)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-17">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerCompletesDepositTx.java</a>
(60)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-18">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerCreatesTLPayoutTx.java</a>
(47)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-19">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerProcessPublishDepositTxMessage.java</a>
(53)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-20">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerPublishesDepositTx.java</a>
(80)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-21">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSendsTLPayoutTx.java</a>
(85)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-22">core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerProcessCompleteDepositTxRequest.java</a>
(36)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-23">desktop/src/main/java/bisq/desktop/main/debug/DebugView.java</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/2245/files#diff-24">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
(3)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/2245.patch'>https://github.com/bisq-network/bisq/pull/2245.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/2245.diff'>https://github.com/bisq-network/bisq/pull/2245.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2245">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttHWYz1dfeUCtjT98kqGn4CbeKpmks5vCK4dgaJpZM4Z7q24">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjjuIkUKGIfyFVb7isv9dvw-QEgdks5vCK4dgaJpZM4Z7q24.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add basic stubs or buyer as maker trade protocol (#2245)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2245"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2245",
"url": "https://github.com/bisq-network/bisq/pull/2245",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>