<p><b>@ManfredKarrer</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2251#discussion_r247491933">core/src/main/java/bisq/core/btc/TxFeeEstimationService.java</a>:</p>
<pre style='color:#555'>> + // We start with min taker fee size of 260
+ int estimatedTxSize = 260;
+ try {
+ estimatedTxSize = getEstimatedTxSize(List.of(tradeFee, amount), estimatedTxSize, txFeePerByte, btcWalletService);
+ } catch (InsufficientMoneyException e) {
+ if (isTaker) {
+ // if we cannot do the estimation we use the payout tx size
+ estimatedTxSize = 380;
+ }
+ log.info("We cannot do the fee estimation because there are not enough funds in the wallet. This is expected " +
+ "if the user pays from an external wallet. In that case we use an estimated tx size of {} bytes.", estimatedTxSize);
+ }
+
+ if (!preferences.isPayFeeInBtc()) {
+ // If we pay the fee in BSQ we have one input more which adds about 150 bytes
+ estimatedTxSize += 150;
</pre>
<p>Yes we can use a constant. It is just used once so thats why I did not use one and the class is small so easty to overlook all as well there is a comment decribing the value. But no problem to make a constant for it.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2251#discussion_r247491933">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtsBPqBleTZ-Ola_VUH421tqH70rDks5vDIb8gaJpZM4Z8Rm0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvNPISMioyjq4lEz2rGnNyDF8NUYks5vDIb8gaJpZM4Z8Rm0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #2251"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2251#discussion_r247491933"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2251#discussion_r247491933",
"url": "https://github.com/bisq-network/bisq/pull/2251#discussion_r247491933",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>