<p><b>@blabno</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2251#discussion_r249274591">core/src/test/java/bisq/core/btc/TxFeeEstimationServiceTest.java</a>:</p>
<pre style='color:#555'>> +    @Ignore
+    public void testGetEstimatedTxSize_withLargeTx() throws InsufficientMoneyException {
+        List<Coin> outputValues = List.of(Coin.valueOf(2000), Coin.valueOf(3000));
+        int initialEstimatedTxSize;
+        Coin txFeePerByte;
+        BtcWalletService btcWalletService = mock(BtcWalletService.class);
+        int result;
+        int realTxSize;
+        Coin txFee;
+
+        initialEstimatedTxSize = 260;
+        txFeePerByte = Coin.valueOf(10);
+        realTxSize = 2600;
+
+        txFee = txFeePerByte.multiply(initialEstimatedTxSize);
+        when(btcWalletService.getEstimatedFeeTxSize(outputValues, txFee)).thenReturn(realTxSize);
</pre>
<p>do/while loop inside <code>getEstimatedFeeTxSize</code> has 2 cycles because first invocation of <code>isInTolerance</code> returns <code>false</code>.<br>
So for the first iteration we have to mock with initial <code>txFee</code>:</p>
<pre><code>when(btcWalletService.getEstimatedFeeTxSize(outputValues, txFee)).thenReturn(realTxSize);
</code></pre>
<p>And for the second iteration we have to mock with <code>txFee</code> multiplied by <code>txFeePerByte</code>.</p>
<pre><code>when(btcWalletService.getEstimatedFeeTxSize(outputValues, txFeePerByte.multiply(realTxSize))).thenReturn(realTxSize)
</code></pre>
<p>Alternatively we can mock <code>getEstimatedFeeTxSize</code> to return the same result for any <code>txFee</code>:</p>
<pre><code>when(btcWalletService.getEstimatedFeeTxSize(eq(outputValues), any(Coin.class))).thenReturn(realTxSize);
</code></pre>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2251#discussion_r249275338">core/src/test/java/bisq/core/btc/TxFeeEstimationServiceTest.java</a>:</p>
<pre style='color:#555'>> +        int realTxSize;
+        Coin txFee;
+
+        initialEstimatedTxSize = 260;
+        txFeePerByte = Coin.valueOf(10);
+        realTxSize = 2600;
+
+        txFee = txFeePerByte.multiply(initialEstimatedTxSize);
+        when(btcWalletService.getEstimatedFeeTxSize(outputValues, txFee)).thenReturn(realTxSize);
+
+        // repeated calls to getEstimatedFeeTxSize do not work (returns 0 at second call in loop which cause test to fail)
+        result = TxFeeEstimationService.getEstimatedTxSize(outputValues, initialEstimatedTxSize, txFeePerByte, btcWalletService);
+        assertEquals(2600, result);
+    }
+
+    // FIXME @Bernard could you have a look?
</pre>
<p>Same as above</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2251#pullrequestreview-194388596">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkK1zOO7---hEwX1HTlUh2jKV8N2ks5vFFh7gaJpZM4Z8Rm0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnpxhOZnJONG6H_MIyvKu_dDtlPnks5vFFh7gaJpZM4Z8Rm0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno commented on #2251"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2251#pullrequestreview-194388596"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2251#pullrequestreview-194388596",
"url": "https://github.com/bisq-network/bisq/pull/2251#pullrequestreview-194388596",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>