<p><b>@blabno</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2289#discussion_r249712556">assets/src/main/java/bisq/asset/coins/Credits.java</a>:</p>
<pre style='color:#555'>> +                return AddressValidationResult.invalidStructure();
+
+            return super.validate(address);
+        }
+    }
+
+
+    public static class CreditsParams extends NetworkParametersAdapter {
+
+        public CreditsParams() {
+            addressHeader = 28;
+            p2shHeader = 5;
+            acceptableAddressCodes = new int[]{addressHeader, p2shHeader};
+        }
+    }
+}
</pre>
<p>Add missing newline</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2289#discussion_r249712609">assets/src/test/java/bisq/asset/coins/CreditsTest.java</a>:</p>
<pre style='color:#555'>> +    @Test
+    public void testValidAddresses() {
+        assertValidAddress("CfXBhPhSxx1wqxGQCryfgn6iU1M1XFUuCo");
+        assertValidAddress("CMde7YERCFWkCL2W5i8uyJmnpCVj8Chhww");
+        assertValidAddress("CcbqU3MLZuGAED2CuhUkquyJxKaSJqv6Vb");
+        assertValidAddress("CKaig5pznaUgiLqe6WkoCNGagNMhNLtqhK");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("1fXBhPhSxx1wqxGQCryfgn6iU1M1XFUuCo32");
+        assertInvalidAddress("CMde7YERCFWkCL2W5i8uyJmnpCVj8Chh");
+        assertInvalidAddress("CcbqU3MLZuGAED2CuhUkquyJxKaSJqv6V6#");
+        assertInvalidAddress("bKaig5pznaUgiLqe6WkoCNGagNMhNLtqhKkggg");
+    }
+}
</pre>
<p>Missing newline</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2289#pullrequestreview-194922229">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtsbSxNbxHVdqbTBgdL5QxNspz64Jks5vFuJXgaJpZM4aIv_I">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtrq0-VfUOYC9jOl-4M4-Rfnga28Bks5vFuJXgaJpZM4aIv_I.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno commented on #2289"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2289#pullrequestreview-194922229"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2289#pullrequestreview-194922229",
"url": "https://github.com/bisq-network/bisq/pull/2289#pullrequestreview-194922229",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>