<p>I tested a number of gradle plugins - robfletcher/gradle-compass didn't quite work (issue with the maven repo) but the <code>anbuck/gradle-compass</code> fork works well in this quick PoC: <a href="https://github.com/bisq-network/bisq/compare/master...peterzen:feature-dark-mode?expand=1">https://github.com/bisq-network/bisq/compare/master...peterzen:feature-dark-mode?expand=1</a></p>
<p>While it's indeed not a major difference in terms of savings in code lines, the ability to use SASS variables and mixins help a lot in keeping duplications low and the UI consistent down the line (not just in terms of color scheme but other things like typography and UI sizing).</p>
<p>IntelliJ has a SASS language support plugin and a linter which makes the editing of the SCSS sources easier on the eye slightly.  I'll play around more with it and see whether the cost/benefit of an extra build step makes sense or not.</p>
<p>I don't have previous experience with SASS/JavaFX beyond reading up on it but found some articles that recommend it for the same reason as in the traditional web dev context.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2286#issuecomment-459406716">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmNSkKeYEy3CDhSS2DqTecKwbssOks5vIxgegaJpZM4aIFnc">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZti_4Bhr1-wwNsCJXxPoMXxGz1pQEks5vIxgegaJpZM4aIFnc.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@peterzen in #2286: I tested a number of gradle plugins - robfletcher/gradle-compass didn't quite work (issue with the maven repo) but the `anbuck/gradle-compass` fork works well in this quick PoC: https://github.com/bisq-network/bisq/compare/master...peterzen:feature-dark-mode?expand=1\r\n\r\nWhile it's indeed not a major difference in terms of savings in code lines, the ability to use SASS variables and mixins help a lot in keeping duplications low and the UI consistent down the line (not just in terms of color scheme but other things like typography and UI sizing).  \r\n\r\nIntelliJ has a SASS language support plugin and a linter which makes the editing of the SCSS sources easier on the eye slightly.  I'll play around more with it and see whether the cost/benefit of an extra build step makes sense or not.\r\n\r\nI don't have previous experience with SASS/JavaFX beyond reading up on it but found some articles that recommend it for the same reason as in the traditional web dev context.\r\n"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/2286#issuecomment-459406716"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2286#issuecomment-459406716",
"url": "https://github.com/bisq-network/bisq/issues/2286#issuecomment-459406716",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>