<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5878500" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/peterzen">@peterzen</a> Please request <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1449498" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a> to add you as contributor and I'm able to assign you to this task.<br>
Regarding SASS, I'm not sure if we can use the traditional tooling here as well. Javafx css looks very similar from the ruleset as regular css, but there are some differences. I did find a plugin that might work with our Gradle setup and JavaFX (<a href="https://github.com/robfletcher/gradle-compass">https://github.com/robfletcher/gradle-compass</a>), but you wouldn't need it if you just want to assign variables.</p>
<pre><code>.root {
    -my-variable: #444;
}
</code></pre>
<p>You can split up the css file in smaller chunks to make it easier to work with. For that, we either have to load them manually or we use additional tooling. I leave the decision to you as long as it works with our current setup and integrates nicely within IntelliJ without doing any manual work during development.<br>
<a href="https://github.com/bisq-network/bisq/blob/bf948101267ac459764cb1a012fb1aeefcfc7e4d/desktop/src/main/java/bisq/desktop/app/BisqApp.java#L221-L224">https://github.com/bisq-network/bisq/blob/bf948101267ac459764cb1a012fb1aeefcfc7e4d/desktop/src/main/java/bisq/desktop/app/BisqApp.java#L221-L224</a><br>
Still in the end I guess we'll need to load at least two files (colors + styles) or have two different compiled files (light style, dark style) that can be switched in the preferences.</p>
<p>Do you have experience using SASS within JavaFX?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/2286#issuecomment-459380293">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtj-4Hbovtzs3R5ntEIGZ_Wfu-kb2ks5vIwgLgaJpZM4aIFnc">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvNhG_h9uVTd1C9M8WjGaHsTsO28ks5vIwgLgaJpZM4aIFnc.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx in #2286: @peterzen Please request @ManfredKarrer to add you as contributor and I'm able to assign you to this task.\r\nRegarding SASS, I'm not sure if we can use the traditional tooling here as well. Javafx css looks very similar from the ruleset as regular css, but there are some differences. I did find a plugin that might work with our Gradle setup and JavaFX (https://github.com/robfletcher/gradle-compass), but you wouldn't need it if you just want to assign variables.\r\n```\r\n.root {\r\n    -my-variable: #444;\r\n}\r\n``` \r\nYou can split up the css file in smaller chunks to make it easier to work with. For that, we either have to load them manually or we use additional tooling. I leave the decision to you as long as it works with our current setup and integrates nicely within IntelliJ without doing any manual work during development.\r\nhttps://github.com/bisq-network/bisq/blob/bf948101267ac459764cb1a012fb1aeefcfc7e4d/desktop/src/main/java/bisq/desktop/app/BisqApp.java#L221-L224\r\nStill in the end I guess we'll need to load at least two files (colors + styles) or have two different compiled files (light style, dark style) that can be switched in the preferences.\r\n\r\nDo you have experience using SASS within JavaFX?"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/2286#issuecomment-459380293"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/2286#issuecomment-459380293",
"url": "https://github.com/bisq-network/bisq/issues/2286#issuecomment-459380293",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>