<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2354#discussion_r253282875">desktop/src/main/java/bisq/desktop/Navigation.java</a>:</p>
<pre style='color:#555'>>  @Slf4j
 public final class Navigation implements PersistedDataHost {
     private static final ViewPath DEFAULT_VIEW_PATH = ViewPath.to(MainView.class, MarketView.class);
 
     public interface Listener {
-        void onNavigationRequested(ViewPath path);
+        void onNavigationRequested(ViewPath path, @Nullable Object data);
</pre>
<p>I think its better to make a second method with the additional param.</p>
<pre><code>public interface Listener {
        default void onNavigationRequested(ViewPath path){
            onNavigationRequested(path, null);
        }
        default void onNavigationRequested(ViewPath path, @Nullable Object data){
            onNavigationRequested(path);
        }
    }
</code></pre>
<p>Then you can avoid all those changed in clients where you pass null. Using <code>default</code> does not force implementing clients to define both methods.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2354#discussion_r253282897">desktop/src/main/java/bisq/desktop/Navigation.java</a>:</p>
<pre style='color:#555'>>      }
 
-    public void navigateTo(ViewPath newPath) {
+    public void navigateTo(ViewPath newPath, Object data) {
</pre>
<p>Can you add <a class="user-mention" data-hovercard-type="organization" data-hovercard-url="/orgs/nullable/hovercard" href="https://github.com/nullable">@nullable</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2354#pullrequestreview-199367375">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtr4lZVLJh6kGPWxpbkIHsGzJR75Sks5vJizbgaJpZM4af084">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtui_UAMUdC57HRefOZvy8ei_pI4Qks5vJizbgaJpZM4af084.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer requested changes on #2354"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2354#pullrequestreview-199367375"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2354#pullrequestreview-199367375",
"url": "https://github.com/bisq-network/bisq/pull/2354#pullrequestreview-199367375",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>