<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2346#discussion_r252623126">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>:</p>
<pre style='color:#555'>> @@ -236,7 +236,6 @@ protected void onSetupCompleted() {
             if (regTestHost == RegTestHost.LOCALHOST) {
                 walletConfig.setPeerNodesForLocalHost();
             } else if (regTestHost == RegTestHost.REMOTE_HOST) {
-                walletConfig.setMinBroadcastConnections(1);
</pre>
<p>Is that correct to remove that line?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2346#discussion_r252623637">core/src/main/java/bisq/core/user/Preferences.java</a>:</p>
<pre style='color:#555'>>                  || bisqEnvironment.isBitcoinLocalhostNodeRunning())
+                && bisqEnvironment.getProperty(BtcOptionKeys.USE_TOR_FOR_BTC).isEmpty())
</pre>
<p>Maybe better to check against a boolean as USE_TOR_FOR_BTC can be set to false. A default values should be set anyway so an empty property should be not be the case if the property setup is done correctly.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2346#pullrequestreview-198533922">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjLYHjff5AhpOaYoa2oEZCmoN87sks5vJkXOgaJpZM4abRsS">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoPN6AM3opl3ija0GwJbSxLlD6Xtks5vJkXOgaJpZM4abRsS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer requested changes on #2346"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2346#pullrequestreview-198533922"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2346#pullrequestreview-198533922",
"url": "https://github.com/bisq-network/bisq/pull/2346#pullrequestreview-198533922",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>