<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a> I changed the tx to IRREGULAR and added some more changes. Tested a bit with proposals, blind vote and vote reveal by delaying the tx broadcast and increasing the blocks in between so that the phase in not valid anymore at the tx confirmation block. Blind votes show irregular state, the others not but that might be ok as long they are not burned. A blind vote did not get unlocked though if no vote reveal followed (maybe the vote reveal tx which we make to unlock did not gor created as the txType is now irregular instead of blind vote?). Was also wondering if we should better keep the original type and add a new boolean flag which marks a tx invalid for dao rules but the BSQ still spendable....<br>
I leave the PR WIP as I am not sure if the additional type is really the best way (and once we add it we cannot remove it anymore).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2364#issuecomment-460095939">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkdKpISlc9WcknVVscAr7JpBsDZUks5vJ2WygaJpZM4agW9c">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtu_8mew0tHl_3YJ8MAo79Q2VHyQOks5vJ2WygaJpZM4agW9c.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2364: @sqrrm I changed the tx to IRREGULAR and added some more changes. Tested a bit with proposals, blind vote and vote reveal by delaying the tx broadcast and increasing the blocks in between so that the phase in not valid anymore at the tx confirmation block. Blind votes show irregular state, the others not but that might be ok as long they are not burned. A blind vote did not get unlocked though if no vote reveal followed (maybe the vote reveal tx which we make to unlock did not gor created as the txType is now irregular instead of blind vote?). Was also wondering if we should better keep the original type and add a new boolean flag which marks a tx invalid for dao rules but the BSQ still spendable....\r\nI leave the PR WIP as I am not sure if the additional type is really the best way (and once we add it we cannot remove it anymore). "}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2364#issuecomment-460095939"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2364#issuecomment-460095939",
"url": "https://github.com/bisq-network/bisq/pull/2364#issuecomment-460095939",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>