<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2242#discussion_r247684816">core/src/main/java/bisq/core/dao/node/parser/TxParser.java</a>:</p>
<pre style='color:#555'>> @@ -248,10 +248,15 @@ private void processIssuance(int blockHeight, TempTx tempTx, long bsqFee) {
                 log.warn("It can be that we have a opReturn which is correct from its structure but the whole tx " +
                         "in not valid as the issuanceCandidate in not there. " +
                         "As the BSQ fee is set it must be either a buggy tx or an manually crafted invalid tx.");
-                tempTx.setTxType(TxType.INVALID);
+                // Even though the request part if invalid the BSQ transfer and change output should still be valid
+                // as long as the BSQ change <= BSQ inputs.
+                tempTx.setTxType(TxType.UNDEFINED_TX_TYPE);
</pre>
<p>Not sure if we should use UNDEFINED_TX_TYPE as it does not describe it correctly. Maybe some weaker term than "invalid"? What about NON_STANDARD or "NON_RULED_COMFORM"?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2242#discussion_r247686159">core/src/main/java/bisq/core/dao/governance/bond/Bond.java</a>:</p>
<pre style='color:#555'>> @@ -53,8 +53,10 @@ protected Bond(T bondedAsset) {
     }
 
     public boolean isActive() {
-        return bondState != BondState.READY_FOR_LOCKUP &&
-                bondState != BondState.UNLOCKED;
+        return bondState == BondState.LOCKUP_TX_CONFIRMED ||
</pre>
<p>I think UNLOCK_TX_PENDING is missing</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2242#discussion_r247687362">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -1635,7 +1635,8 @@ dao.wallet.dashboard.price=Latest BSQ/BTC trade price (in Bisq)
 dao.wallet.dashboard.marketCap=Market capitalisation (based on trade price)
 
 dao.wallet.receive.fundYourWallet=Fund your BSQ wallet
-dao.wallet.receive.bsqAddress=BSQ wallet address
+dao.wallet.receive.bsqAddress=BSQ wallet address (This is a new unused address to avoid address reuse, \
</pre>
<p>That is quite verbose. What about:<br>
Fresh unused BSQ wallet address</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2242#pullrequestreview-192395885">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttvu2Sx4sPvkF03u038h8x0jYOqPks5vJvnwgaJpZM4Z7aJu">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtiW5oY3Uzzn1wd7GxjwVpLOXK8mIks5vJvnwgaJpZM4Z7aJu.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer requested changes on #2242"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2242#pullrequestreview-192395885"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2242#pullrequestreview-192395885",
"url": "https://github.com/bisq-network/bisq/pull/2242#pullrequestreview-192395885",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>