<p><b>@devinbileck</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2346#discussion_r253362484">core/src/main/java/bisq/core/user/Preferences.java</a>:</p>
<pre style='color:#555'>>                  || bisqEnvironment.isBitcoinLocalhostNodeRunning())
+                && bisqEnvironment.getProperty(BtcOptionKeys.USE_TOR_FOR_BTC).isEmpty())
</pre>
<p>After reviewing the code again, my initial implementation appears to be technically correct and attempts to determine if the USE_TOR_FOR_BTC parameter was explicitly provided or not by checking whether the property is empty (which it will be empty if not provided). And if it is provided, do not override it to false and instead use whatever value was provided. It handles each scenario where (1) the parameter is not provided, (2) provided and set to false, and (3) provided and set to true. I did not change the implementation/type of the USE_TOR_FOR_BTC as a string parameter to boolean in order to keep it consistent with other similar parameters. If that needs to change, that can be done separately. The only thing I identified was that I should have instead used the useTorFlagFromOptions parameter rather than bisqEnvironment.getProperty. I will commit a fix for that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2346#discussion_r253362484">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthFcGqzO0B9IEzjCbAng8XcaEcSEks5vJ9w-gaJpZM4abRsS">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtp-VKYQqY4SeAyBKoNtRRyCdyhNWks5vJ9w-gaJpZM4abRsS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@devinbileck commented on #2346"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2346#discussion_r253362484"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2346#discussion_r253362484",
"url": "https://github.com/bisq-network/bisq/pull/2346#discussion_r253362484",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>