<p><b>@ripcurlx</b> requested changes on this pull request.</p>
<p>NACK - see my comments below. Unfortunately I don't have time to evaluate if we want to "offically" support Snap packages. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a> do you have time to look into this if we want to add this kind of support? Thanks!</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2378#discussion_r254343462">snap/snapcraft.yaml</a>:</p>
<pre style='color:#555'>> +icon: icon.png
+
+apps:
+ bisq-desktop:
+ command: desktop-launch "$SNAP/opt/bisq/bin/bisq-desktop"
+ plugs:
+ - network
+ - network-bind
+ - desktop
+ - desktop-legacy
+ - x11
+ - wayland
+ - home
+ desktop: usr/share/applications/bisq.desktop
+ environment:
+ JAVA_HOME: "$SNAP/usr/lib/jvm/java-11-openjdk-amd64"
</pre>
<p>Bisq should be built with Java 10. Java 11 isn't officially supported yet.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2378#discussion_r254343603">snap/snapcraft.yaml</a>:</p>
<pre style='color:#555'>> +parts:
+ bisq:
+ plugin: gradle
+ override-build: |
+ ./gradlew build
+
+ # Install executable.
+ install -d "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+ cp -r desktop/build/app/* "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+
+ # Install desktop launcher icon
+ install -Dm644 desktop/package/linux/icon.png "${SNAPCRAFT_PART_INSTALL}/usr/share/pixmaps/bisq.png"
+
+ source: https://github.com/bisq-network/bisq-desktop.git
+ source-tag: v0.9.3
+ build-packages: [openjdk-11-jdk]
</pre>
<p>Bisq should be built with Java 10. Java 11 isn't officially supported yet.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2378#discussion_r254343633">snap/snapcraft.yaml</a>:</p>
<pre style='color:#555'>> + bisq:
+ plugin: gradle
+ override-build: |
+ ./gradlew build
+
+ # Install executable.
+ install -d "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+ cp -r desktop/build/app/* "${SNAPCRAFT_PART_INSTALL}/opt/bisq"
+
+ # Install desktop launcher icon
+ install -Dm644 desktop/package/linux/icon.png "${SNAPCRAFT_PART_INSTALL}/usr/share/pixmaps/bisq.png"
+
+ source: https://github.com/bisq-network/bisq-desktop.git
+ source-tag: v0.9.3
+ build-packages: [openjdk-11-jdk]
+ stage-packages: [openjdk-11-jre]
</pre>
<p>Bisq should be built with Java 10. Java 11 isn't officially supported yet.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2378#pullrequestreview-200669786">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqdH7IKZrOE6O80GpG4CQrEPZ3kWks5vKwIhgaJpZM4alJ7Y">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuSeg0VHDzR-ujMv4sm0uVieZZ-Bks5vKwIhgaJpZM4alJ7Y.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx requested changes on #2378"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2378#pullrequestreview-200669786"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2378#pullrequestreview-200669786",
"url": "https://github.com/bisq-network/bisq/pull/2378#pullrequestreview-200669786",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>