It's not rejected. Adjust the code and amend commit.<br>
<br>
Sent from ProtonMail mobile<br>
<br>
-------- Original Message --------<br>
On 7 Feb 2019, 09:00, Nico Krause wrote:<br>
<br>
> @inspiraluna commented on this pull request.<br>
><br>
> ---------------------------------------------------------------<br>
><br>
> In [assets/src/main/java/bisq/asset/coins/Doichain.java](https://github.com/bisq-network/bisq/pull/2347#discussion_r254576471):<br>
><br>
>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public<br>
> + * License for more details.<br>
> + *<br>
> + * You should have received a copy of the GNU Affero General Public License<br>
> + * along with Bisq. If not, see <http://www.gnu.org/licenses/>.<br>
> + */<br>
> +<br>
> +package bisq.asset.coins;<br>
> +<br>
> +import bisq.asset.Coin;<br>
> +import bisq.asset.DefaultAddressValidator;<br>
> +<br>
> +public class Doichain extends Coin {<br>
> +<br>
> +    public Doichain() {<br>
> +        super("Doichain", "DOI", new DefaultAddressValidator());<br>
><br>
> we are strongly based on Namecoin, so I used Namecoin as an example. This probably means this PR gets rejected. So I'll look again to find an up-to-date validator.<br>
><br>
> —<br>
> You are receiving this because you were assigned.<br>
> Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/pull/2347#discussion_r254576471), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2M1g28NGa0wwW_1gi48fK_vy_u4Zks5vK90zgaJpZM4abbaW).

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2347#issuecomment-461325056">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqkfyv0SfMmBexJ14Q7P0-xyK94Rks5vK-EugaJpZM4abbaW">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZttISLgNAfg38wouGAB8qV8zrXNUXks5vK-EugaJpZM4abbaW.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno in #2347: It's not rejected. Adjust the code and amend commit.\n\nSent from ProtonMail mobile\n\n-------- Original Message --------\nOn 7 Feb 2019, 09:00, Nico Krause wrote:\n\n\u003e @inspiraluna commented on this pull request.\n\u003e\n\u003e ---------------------------------------------------------------\n\u003e\n\u003e In [assets/src/main/java/bisq/asset/coins/Doichain.java](https://github.com/bisq-network/bisq/pull/2347#discussion_r254576471):\n\u003e\n\u003e\u003e + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public\n\u003e + * License for more details.\n\u003e + *\n\u003e + * You should have received a copy of the GNU Affero General Public License\n\u003e + * along with Bisq. If not, see \u003chttp://www.gnu.org/licenses/\u003e.\n\u003e + */\n\u003e +\n\u003e +package bisq.asset.coins;\n\u003e +\n\u003e +import bisq.asset.Coin;\n\u003e +import bisq.asset.DefaultAddressValidator;\n\u003e +\n\u003e +public class Doichain extends Coin {\n\u003e +\n\u003e +    public Doichain() {\n\u003e +        super(\"Doichain\", \"DOI\", new DefaultAddressValidator());\n\u003e\n\u003e we are strongly based on Namecoin, so I used Namecoin as an example. This probably means this PR gets rejected. So I'll look again to find an up-to-date validator.\n\u003e\n\u003e —\n\u003e You are receiving this because you were assigned.\n\u003e Reply to this email directly, [view it on GitHub](https://github.com/bisq-network/bisq/pull/2347#discussion_r254576471), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2M1g28NGa0wwW_1gi48fK_vy_u4Zks5vK90zgaJpZM4abbaW)."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2347#issuecomment-461325056"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2347#issuecomment-461325056",
"url": "https://github.com/bisq-network/bisq/pull/2347#issuecomment-461325056",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>