<p><b>@sqrrm</b> commented on this pull request.</p>

<p>See comment on animation on error.  Apart from that it looks good.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2384#discussion_r255331967">desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java</a>:</p>
<pre style='color:#555'>>                  },
-                errorMessage -> new Popup<>().warning(errorMessage).show());
+                errorMessage -> {
+                    new Popup<>().warning(errorMessage).show();
+                    makeProposalButton.setDisable(false);
</pre>
<p>By not disabling the busyAnimation/button here it will keep spinning after an error was reported, I don't think that's correct.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2384#pullrequestreview-201897374">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtpk_EYhF4G33o7wsfsHSJIzuFf56ks5vL_bMgaJpZM4am27n">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtp4iR3mW60LX7DO2Ml-cfCMN6tCeks5vL_bMgaJpZM4am27n.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #2384"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2384#pullrequestreview-201897374"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2384#pullrequestreview-201897374",
"url": "https://github.com/bisq-network/bisq/pull/2384#pullrequestreview-201897374",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>