<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2379#discussion_r255524658">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -373,6 +373,7 @@ createOffer.fundsBox.networkFee=Mining fee
 createOffer.fundsBox.placeOfferSpinnerInfo=Offer publishing is in progress ...
 createOffer.fundsBox.paymentLabel=Bisq trade with ID {0}
 createOffer.fundsBox.fundsStructure=({0} security deposit, {1} trade fee, {2} mining fee)
+createOffer.fundsBox.fundsStructure.BSQ=({0} security deposit, {1} mining fee) + {2} trade fee
</pre>
<p>On first sight yes, but we have this order on a couple of places and it makes sense from my point of view to have it as it is right now:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/52568611-8a3ab080-2e0f-11e9-827d-b27bfbb2ad6d.png"><img width="604" alt="bildschirmfoto 2019-02-11 um 15 12 05" src="https://user-images.githubusercontent.com/170962/52568611-8a3ab080-2e0f-11e9-827d-b27bfbb2ad6d.png" style="max-width:100%;"></a></p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/52568601-83ac3900-2e0f-11e9-9948-a346eaed6086.png"><img width="986" alt="bildschirmfoto 2019-02-11 um 15 11 08" src="https://user-images.githubusercontent.com/170962/52568601-83ac3900-2e0f-11e9-9948-a346eaed6086.png" style="max-width:100%;"></a></p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/52568700-ce2db580-2e0f-11e9-8181-3e9bbc68de26.png"><img width="1138" alt="bildschirmfoto 2019-02-11 um 15 14 44" src="https://user-images.githubusercontent.com/170962/52568700-ce2db580-2e0f-11e9-8181-3e9bbc68de26.png" style="max-width:100%;"></a></p>
<p>The only problem is to mix it in the total funds field with the BSQ value.<br>
I personally would  go with this little inconsistency and have the order in this field different between BSQ and BTC trading fees.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2379#discussion_r255524658">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtixw7xLQn4r412Q_Qm6GC1YJc8WWks5vMXt8gaJpZM4all8q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjYqM4_K4jdb0duRjQFWZ_GlKcmBks5vMXt8gaJpZM4all8q.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx commented on #2379"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2379#discussion_r255524658"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2379#discussion_r255524658",
"url": "https://github.com/bisq-network/bisq/pull/2379#discussion_r255524658",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>