<p>As I commented on the PR upstream <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407885489" data-permission-text="Issue title is private" data-url="https://github.com/bitcoinj/bitcoinj/issues/1695" data-hovercard-type="pull_request" data-hovercard-url="/bitcoinj/bitcoinj/pull/1695/hovercard" href="https://github.com/bitcoinj/bitcoinj/pull/1695">bitcoinj/bitcoinj#1695</a>, stop using memory mapped files implies a performance degradation.</p>
<p>Whether the performance degradation is tiny or huge is something that has to be found out during testing. This kind of testing may be hard and confusing, because the conclusions may not be definitive.</p>
<p>It would be important to see if the unresponsive <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a> experienced is related to this PR or not.</p>
<p>Maybe he or someone else can do another test and see if the UI becomes unresponsive again.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2403#issuecomment-463184773">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttc88m3j_fUyOBF8JH3bBuv0jdLiks5vNAfHgaJpZM4a0Tob">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoXTZageHaWpwm2f_Bf4oJEEXRufks5vNAfHgaJpZM4a0Tob.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@oscarguindzberg in #2403: As I commented on the PR upstream https://github.com/bitcoinj/bitcoinj/pull/1695, stop using memory mapped files implies a performance degradation.\r\n\r\nWhether the performance degradation is tiny or huge is something that has to be found out during testing. This kind of testing may be hard and confusing, because the conclusions may not be definitive.\r\n\r\nIt would be important to see if the unresponsive @devinbileck experienced is related to this PR or not. \r\n\r\nMaybe he or someone else can do another test and see if the UI becomes unresponsive again."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2403#issuecomment-463184773"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2403#issuecomment-463184773",
"url": "https://github.com/bisq-network/bisq/pull/2403#issuecomment-463184773",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>