<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298">p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java</a>:</p>
<pre style='color:#555'>>                  // Furthermore, we have no hidden services started yet, so there is no graceful
                 // shutdown needed either
-                System.exit(1);
+                UserThread.execute(() -> {
+                    setupListeners.stream().forEach(s -> s.onSetupFailed(new RuntimeException(e.getMessage())));
+                });
             } catch (Throwable ignore) {
             }
</pre>
<p>Maybe we can force <code>onSuccess</code> by <code>return null;</code> after triggering the <code>onSetupFailed</code> and let the <code>onFailure</code> be?</p>
<p>And yes, this class cries for being refactored :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtsVyOcnnQ4Zs1QZXBDfUOlltPWI8ks5vM-UNgaJpZM4ax4Nl">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtv1f-wiFPp2sioN6XWcMPJ5wKHsGks5vM-UNgaJpZM4ax4Nl.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@freimair commented on #2399"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298",
"url": "https://github.com/bisq-network/bisq/pull/2399#discussion_r256326298",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>