<p>Sure, it will be zero-dependency code, including own Keccak1600 hashing class and Monero Base58 decoder.</p>
<p>What way would you prefer:</p>
<ol>
<li>Place <code>Keccak1600</code> and <code>MoneroBase58</code> private classes right in the <code>CryptonoteAddressValidator.java</code> source.<br>
Given that both won't be used elsewhere in the bitsq codebase, looks good to me.<br>
Though might be somewhat less appropriate from Bisq code organization point of view.</li>
<li>Place <code>Keccak1600</code> and <code>MoneroBase58</code> classes in <code>bisq.common.crypto</code></li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1652#issuecomment-463601058">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtk1vQlpbreoTe9IYLTDqTN-S7Mn2ks5vNU8igaJpZM4WdHIv">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnYivibSPvWBG3AoqCYIzWZT2Bokks5vNU8igaJpZM4WdHIv.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@xiphon in #1652: Sure, it will be zero-dependency code, including own Keccak1600 hashing class and Monero Base58 decoder.\r\n\r\nWhat way would you prefer:\r\n1. Place `Keccak1600` and `MoneroBase58` private classes right in the `CryptonoteAddressValidator.java` source.\r\nGiven that both won't be used elsewhere in the bitsq codebase, looks good to me.\r\nThough might be somewhat less appropriate from Bisq code organization point of view.\r\n2. Place `Keccak1600` and `MoneroBase58` classes in `bisq.common.crypto`"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1652#issuecomment-463601058"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1652#issuecomment-463601058",
"url": "https://github.com/bisq-network/bisq/issues/1652#issuecomment-463601058",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>