<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #1652.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="357694184" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq/issues/1652" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1652/hovercard" href="https://github.com/bisq-network/bisq/issues/1652">#1652</a></p>
<p>Implements address decoding, checksum validation, prefix matching and public keys length checks.<br>
The code is consistent with Monero codebase.</p>
<p>Supports all the other Cryptonote coins as well.</p>
<p>PS:<br>
Skips <code>Cash2</code> checksum validation (the coin uses <code>BLAKE2b</code> instead of <code>Keccak1600</code>), but there are still plenty of other checks out there.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2422'>https://github.com/bisq-network/bisq/pull/2422</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Implement correct and complete Monero and Cryptonote address validator</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-0">assets/src/main/java/bisq/asset/CryptonoteAddressValidator.java</a>
    (324)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-1">assets/src/main/java/bisq/asset/coins/Aeon.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-2">assets/src/main/java/bisq/asset/coins/Blur.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-3">assets/src/main/java/bisq/asset/coins/Cash2.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-4">assets/src/main/java/bisq/asset/coins/FourtyTwo.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-5">assets/src/main/java/bisq/asset/coins/Mask.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2422/files#diff-6">assets/src/main/java/bisq/asset/coins/Monero.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2422.patch'>https://github.com/bisq-network/bisq/pull/2422.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2422.diff'>https://github.com/bisq-network/bisq/pull/2422.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2422">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvw2_gF02F35sSytSkZzWid9MTbhks5vNg7GgaJpZM4a8xGw">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtmxu86yAdQNdP0xr25fVmgvuq9CUks5vNg7GgaJpZM4a8xGw.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Implement correct and complete Monero and Cryptonote address validator (#2422)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2422"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2422",
"url": "https://github.com/bisq-network/bisq/pull/2422",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>