<p>I did some very basic test with an older not synced app on mainnet with using NonMMappedSPVBlockStore and SPVBlockStore. 2318 blocks where downloaded.<br>
As I am on OSX so I just changed the if switch to enable NonMMappedSPVBlockStore.</p>
<p>I had Bitcoin core locally to avoid too much influence from network conditions.<br>
I run 3 times with replacing the original outdated data directory to trigger the  download of all 2318 blocks:</p>
<p>SPVBlockStore:   51417 ms, 68965 ms, 68922 ms<br>
NonMMappedSPVBlockStore:   92405 ms, 83738 ms, 71824 ms</p>
<p>So NonMMappedSPVBlockStore is a bit slower but not too critical.<br>
Of course that is just one use case and is not sufficient to be sure if there is not more serious performance degradation, but I think it is ok to take the risk to merge that now.</p>
<p>I would prefer to not apply that to all OS but keep it as it is only for Windows.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2403#issuecomment-463799943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtn3P70yzH_blf8TVy9lnThLE8tDwks5vNdIPgaJpZM4a0Tob">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtpNBu7uhkBT0fJT8bb8c_QxfWTs9ks5vNdIPgaJpZM4a0Tob.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2403: I did some very basic test with an older not synced app on mainnet with using NonMMappedSPVBlockStore and SPVBlockStore. 2318 blocks where downloaded.\r\nAs I am on OSX so I just changed the if switch to enable NonMMappedSPVBlockStore.\r\n\r\nI had Bitcoin core locally to avoid too much influence from network conditions.\r\nI run 3 times with replacing the original outdated data directory to trigger the  download of all 2318 blocks:\r\n\r\nSPVBlockStore:   51417 ms, 68965 ms, 68922 ms\r\nNonMMappedSPVBlockStore:   92405 ms, 83738 ms, 71824 ms\r\n\r\nSo NonMMappedSPVBlockStore is a bit slower but not too critical.\r\nOf course that is just one use case and is not sufficient to be sure if there is not more serious performance degradation, but I think it is ok to take the risk to merge that now.\r\n\r\nI would prefer to not apply that to all OS but keep it as it is only for Windows.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2403#issuecomment-463799943"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2403#issuecomment-463799943",
"url": "https://github.com/bisq-network/bisq/pull/2403#issuecomment-463799943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>