<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comments.</p>
<p>Also please squash those commits into a single one.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2385#discussion_r257572397">assets/src/test/java/bisq/asset/coins/DSTRATest.java</a>:</p>
<pre style='color:#555'>> +
+public class DSTRATest extends AbstractAssetTest {
+
+    public DSTRATest() {
+        super(new DSTRA());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+        assertValidAddress("DQcAKx5bFoeRwAEHE4EHQykyq8u2M1pwFa");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd77");
</pre>
<p>Please format the code according to Bisq code style.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2385#discussion_r257572442">assets/src/test/java/bisq/asset/coins/DSTRATest.java</a>:</p>
<pre style='color:#555'>> +    @Test
+    public void testValidAddresses() {
+        assertValidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+        assertValidAddress("DQcAKx5bFoeRwAEHE4EHQykyq8u2M1pwFa");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd77");
+        assertInvalidAddress("DGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd");
+               assertInvalidAddress("dGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+               assertInvalidAddress("FGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+               assertInvalidAddress("fGiwGS8n3tJZuKxUdWF6MyTYvv6xgDcyd7");
+               
+    }
+}
</pre>
<p>Add newline at the end of file.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2385#pullrequestreview-204637654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjClNo8gC7eMsW_3lWHXTu62SnW4ks5vOkwYgaJpZM4am5ch">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtkFj6BM433qbBLEKN8r3-P-_6KRFks5vOkwYgaJpZM4am5ch.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno requested changes on #2385"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2385#pullrequestreview-204637654"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2385#pullrequestreview-204637654",
"url": "https://github.com/bisq-network/bisq/pull/2385#pullrequestreview-204637654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>