<p>To avoid the issue with lost taker fees if the take-offer attempt fails,<br>
we delay the publishing of the taker fee tx just before the deposit tx<br>
gets published.<br>
The taker fee tx must not be committed to the wallet to avoid that the<br>
wallet would require a resync in case the tx is not published.<br>
If the tx is not committed the addresses used there are not considered<br>
as used and that would cause issues with the address entry context<br>
assignment for the deposit tx. To avoid those issues we need to force<br>
the creation of new addresses used for the multisig and payout address<br>
entries. To be sure that happens before any of the following tasks make<br>
use of those address entries we do that already in the createTakerFee<br>
task.<br>
For BSQ fee tx it behaves similar but needs separate testing.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/2488'>https://github.com/bisq-network/bisq/pull/2488</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Delay broadcasting of taker fee tx</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-0">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-1">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>
    (48)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-2">core/src/main/java/bisq/core/offer/OpenOffer.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-3">core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-4">core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-5">core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-6">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-7">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-8">core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java</a>
    (93)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-9">core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerPublishFeeTx.java</a>
    (110)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/2488/files#diff-10">core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerSendPayDepositRequest.java</a>
    (7)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/2488.patch'>https://github.com/bisq-network/bisq/pull/2488.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/2488.diff'>https://github.com/bisq-network/bisq/pull/2488.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2488">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmVT_MC6WxZ-IODtZ8pWbknW37-iks5vSfahgaJpZM4baKCw">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsKoTbspU8RUgqRnMdZrDEL2BREnks5vSfahgaJpZM4baKCw.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Delay broadcasting of taker fee tx (#2488)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2488"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2488",
"url": "https://github.com/bisq-network/bisq/pull/2488",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>