<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=10667901" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ben-kaufman">@ben-kaufman</a><br>
Thanks for adding the translations as well but unfortunately those will be overwritten at next release from Transifex files. We only should edit the default property file in english and the translations have to be done in Transifex. I will leave the commits, just wanted to let you know that the will be lost if no one will move them to Transifex.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2504#issuecomment-470298307">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthJp0xI6JDg3rg7rtbLU0zZff4FGks5vUD1mgaJpZM4bhRUx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsfUvjzR5v6k1ii7o3RUPfdbfniIks5vUD1mgaJpZM4bhRUx.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #2504: @ben-kaufman \r\nThanks for adding the translations as well but unfortunately those will be overwritten at next release from Transifex files. We only should edit the default property file in english and the translations have to be done in Transifex. I will leave the commits, just wanted to let you know that the will be lost if no one will move them to Transifex."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2504#issuecomment-470298307"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2504#issuecomment-470298307",
"url": "https://github.com/bisq-network/bisq/pull/2504#issuecomment-470298307",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>