<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>
<p>Thanks for the fast implementation! Looks basically very good, just a few Nits...</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263048517">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.fxml</a>:</p>
<pre style='color:#555'>> @@ -29,4 +31,7 @@
<columnConstraints>
<ColumnConstraints percentWidth="100"/>
</columnConstraints>
+ <HBox GridPane.rowIndex="8" GridPane.columnSpan="3" alignment="BOTTOM_RIGHT">
</pre>
<p>We do not use FXML anymore beside of the containers (one day we want to get rid completely of it) as it has bad performance and is too limited for more dynamic content. There are still relicts but new code we want to have in Java only. See FormBuilder as out Util for UI components.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263048955">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>> @@ -105,6 +112,7 @@
private final Preferences preferences;
private final BsqFormatter bsqFormatter;
private final Navigation navigation;
+ public AutoTooltipButton exportButton;
</pre>
<p>Would be private once removed from FXML</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263049713">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>> selectedVoteResultListItemListener = (observable, oldValue, newValue) -> onResultsListItemSelected(newValue);
createCyclesTable();
+ exportButton.updateText(Res.get("shared.exportJSON"));
</pre>
<p>Here would be the code or creating the Button.<br>
E.g. <code>button = FormBuilder.addButtonAfterGroup( gridPane, rowIndex, title);</code></p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263050339">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>> @@ -172,6 +182,57 @@ protected void activate() {
cyclesTableView.getSelectionModel().selectedItemProperty().addListener(selectedVoteResultListItemListener);
fillCycleList();
+ exportButton.setOnAction(event -> {
</pre>
<p>I would prefer to delegate that to a method to keep the activate() method short and easy to understand.<br>
E.g. <code>exportButton.setOnAction(event -> doExportToJson()</code></p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263051791">desktop/src/main/java/bisq/desktop/util/GUIUtil.java</a>:</p>
<pre style='color:#555'>> @@ -268,6 +275,21 @@ public static void importAccounts(User user, String fileName, Preferences prefer
}
}
+ public static void exportJSON(String fileName, JsonElement data, Stage stage) {
</pre>
<p>Is there a pretty print feature in the json framework? Would be nice to have, but if not no worry.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263053758">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>> @@ -172,6 +182,57 @@ protected void activate() {
cyclesTableView.getSelectionModel().selectedItemProperty().addListener(selectedVoteResultListItemListener);
fillCycleList();
+ exportButton.setOnAction(event -> {
</pre>
<p>Could you add all fields (if missing, havve not checked all) from the domain objects which are currently not displayed in the UI.<br>
We want to add popups for that anyway and for the json I think its good to have the complete domain data.</p>
<p>The CompensationProposal is missing <code>requestedBsq</code> and <code>bsqAddress</code>. As said the UI does not show all that yet but would be good to have that in the json.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/2504#discussion_r263053920">desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java</a>:</p>
<pre style='color:#555'>> @@ -172,6 +182,57 @@ protected void activate() {
cyclesTableView.getSelectionModel().selectedItemProperty().addListener(selectedVoteResultListItemListener);
fillCycleList();
+ exportButton.setOnAction(event -> {
</pre>
<p>For Proposal there are a few subclasses with diff. fields...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2504#pullrequestreview-211366119">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthnVucpNUBLfCHnIopwIgGSjw3uKks5vT_zvgaJpZM4bhRUx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtkDjXm_svq_0pkrUtHnueP_9FBgoks5vT_zvgaJpZM4bhRUx.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer requested changes on #2504"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2504#pullrequestreview-211366119"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2504#pullrequestreview-211366119",
"url": "https://github.com/bisq-network/bisq/pull/2504#pullrequestreview-211366119",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>