<p><b>@freimair</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246">common/src/main/java/bisq/common/app/Capabilities.java</a>:</p>
<pre style='color:#555'>>      }
 
-    // Application need to set supported capabilities at startup
-    @Getter
-    @Setter
-    private static List<Integer> supportedCapabilities = new ArrayList<>();
+    public void resetCapabilities(Capabilities capabilities) {
+        resetCapabilities(capabilities.capabilities);
+    }
+
+    public void resetCapabilities(Collection<Capability> capabilities) {
</pre>
<p>hm interesting. A <code>setCapabilities</code> seems to me clear as it replaces all capabilities, a <code>resetCaps</code> indicates more strongly, that the capabilities are going to be replaced. I would understand a  <code>clearCapabilities</code> as a clear without add.</p>
<p>Again, in a collection of events logs, a reset clears the log. Hm. <code>setCapabilities</code> or simply <code>set</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtrgHSVaFBma4pRg_FO1euQrGm7Cbks5vUPOagaJpZM4bRz-x">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvml_xcjv4IpMNkQIex8IcPKnEzTks5vUPOagaJpZM4bRz-x.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@freimair commented on #2469"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246",
"url": "https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>